Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375403002: Replace MessageLoopProxy with ThreadTaskRunnerHandle in src/sync/. (Closed)

Created:
6 years, 5 months ago by maniscalco
Modified:
6 years, 5 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy with ThreadTaskRunnerHandle in src/sync/. MessageLoopProxy is deprecated. BUG=391045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282129

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -32 lines) Patch
M sync/api/attachments/attachment_service_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sync/api/attachments/attachment_service_proxy.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M sync/api/attachments/attachment_service_proxy_for_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/api/sync_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/model_type_sync_proxy_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/attachments/attachment_downloader_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sync/internal_api/attachments/fake_attachment_store.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/fake_attachment_store_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sync/internal_api/http_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/sync_context_proxy_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M sync/internal_api/sync_context_proxy_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/model_type_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/sessions/model_type_registry_unittest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M sync/syncable/syncable_unittest.cc View 1 chunk +1 line, -0 lines 1 comment Download
M sync/tools/sync_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
maniscalco
Richard, would you please review this clean-up CL? https://codereview.chromium.org/375403002/diff/30021/sync/syncable/syncable_unittest.cc File sync/syncable/syncable_unittest.cc (right): https://codereview.chromium.org/375403002/diff/30021/sync/syncable/syncable_unittest.cc#newcode127 sync/syncable/syncable_unittest.cc:127: base::MessageLoop ...
6 years, 5 months ago (2014-07-09 18:53:40 UTC) #1
rlarocque
LGTM.
6 years, 5 months ago (2014-07-09 19:08:07 UTC) #2
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 5 months ago (2014-07-09 19:55:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/375403002/30021
6 years, 5 months ago (2014-07-09 19:58:12 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 21:28:13 UTC) #5
Message was sent while issue was closed. 
Change committed as 282129

Powered by Google App Engine
This is Rietveld 408576698