Issue 375393002: DevTools: factor out InspectorFrontendHost/API as a separate entity (chrome)

Issue 375393002: DevTools: factor out InspectorFrontendHost/API as a separate entity (chrome) (Closed)

Created:
6 years, 5 months ago by pfeldman

Modified:
6 years, 5 months ago

Reviewers:
Tom Sepez, vsevik, dgozman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: factor out InspectorFrontendHost/API as a separate entity (chrome) TBR=tsepez (no changes to semantics) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282234

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -78 lines)			Patch
M	chrome/browser/devtools/devtools_embedder_message_dispatcher.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/devtools/devtools_embedder_message_dispatcher.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/devtools/devtools_ui_bindings.h	View	5 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/devtools/devtools_ui_bindings.cc	View	5 chunks	+28 lines, -62 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

@tsepez: this change removes generic subscribe/unsubscribe methods from devtools_embedder_message_dispatcher.h and replaces them with explicit set*UpdatesEnabled ...

6 years, 5 months ago (2014-07-09 16:14:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/375393002/1

6 years, 5 months ago (2014-07-09 18:29:47 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-10 02:33:53 UTC) #6

Message was sent while issue was closed.

Change committed as 282234

Expand Messages | Collapse Messages