LayoutTests/webaudio/offlineaudiocontext-constructor.html - Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/webaudio/offlineaudiocontext-constructor.html

Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix as review Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt » ('j') | Source/modules/webaudio/AudioBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/webaudio/offlineaudiocontext-constructor.html

diff --git a/LayoutTests/webaudio/offlineaudiocontext-constructor.html b/LayoutTests/webaudio/offlineaudiocontext-constructor.html

index a3d3f7147b7abdb0dc32385014e437cfa8e5aa87..c7b0f60263e7917736275adc929968c17f931ea9 100644

--- a/LayoutTests/webaudio/offlineaudiocontext-constructor.html

+++ b/LayoutTests/webaudio/offlineaudiocontext-constructor.html

@@ -10,6 +10,17 @@ description("Tests the OfflineAudioContext constructor");

// Make sure we don't crash when giving 0 as number of frames.

shouldThrow("new OfflineAudioContext(1, 0, 44100)");

+// Make sure we don't throw exception supported ranges of sample rate with min/max.

Raymond Toy 2014/09/04 17:27:20 Fix up phrasing: // Make sure we don't throw exce

KhNo 2014/09/05 05:03:25 Done.

+shouldNotThrow("new OfflineAudioContext(2, 512, 3000)");

+shouldNotThrow("new OfflineAudioContext(2, 512, 192000)");

+// Make sure we don't throw exception supported ranges of sample rate.

Raymond Toy 2014/09/04 17:27:20 Probably don't need this if you change the comment

KhNo 2014/09/05 05:03:25 Done.

+shouldNotThrow("new OfflineAudioContext(2, 512, 8000)");

+shouldNotThrow("new OfflineAudioContext(2, 512, 11025)");

+shouldNotThrow("new OfflineAudioContext(2, 512, 22050)");

+shouldNotThrow("new OfflineAudioContext(2, 512, 44100)");

+shouldNotThrow("new OfflineAudioContext(2, 512, 48000)");

+shouldNotThrow("new OfflineAudioContext(2, 512, 88200)");

+shouldNotThrow("new OfflineAudioContext(2, 512, 96000)");

</script>

</body>

</html>