LayoutTests/webaudio/offlineaudiocontext-constructor.html - Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/webaudio/offlineaudiocontext-constructor.html

Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update layoutTest Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt » ('j') | Source/modules/webaudio/AudioContext.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 <script src="resources/compatibility.js"></script>	5 <script src="resources/compatibility.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <script>	8 <script>

9 description("Tests the OfflineAudioContext constructor");	9 description("Tests the OfflineAudioContext constructor");

10	10

11 // Make sure we don't crash when giving 0 as number of frames.	11 // Make sure we don't crash when giving 0 as number of frames.

12 shouldThrow("new OfflineAudioContext(1, 0, 44100)");	12 shouldThrow("new OfflineAudioContext(1, 0, 44100)");

	13 // Make sure throwing exception about out of sample rate range.

	14 shouldThrow("new OfflineAudioContext(2, 512, 4000)");

	15 shouldThrow("new OfflineAudioContext(2, 512, 98000)");
	Raymond Toy 2014/07/30 16:49:38 Aren't these two tests already covered in dom-exce Aren't these two tests already covered in dom-exceptions? Unless you specifically want to test 4000 and 98000, I would just use the ones from dom-exceptions. KhNo 2014/07/31 16:45:53 Yes, it can be replaced. I think it doesn't need t Show quoted text On 2014/07/30 16:49:38, Raymond Toy wrote: > Aren't these two tests already covered in dom-exceptions? Unless you > specifically want to test 4000 and 98000, I would just use the ones from > dom-exceptions. Yes, it can be replaced. I think it doesn't need to test duplicately.
	16 // Make sure we don't throw exception supported ranges of sample rate.

	17 shouldNotThrow("new OfflineAudioContext(2, 512, 8000)");

	18 shouldNotThrow("new OfflineAudioContext(2, 512, 11025)");

	19 shouldNotThrow("new OfflineAudioContext(2, 512, 22050)");

	20 shouldNotThrow("new OfflineAudioContext(2, 512, 44100)");

	21 shouldNotThrow("new OfflineAudioContext(2, 512, 88200)");

	22 shouldNotThrow("new OfflineAudioContext(2, 512, 96000)");
	Raymond Toy 2014/07/30 16:49:38 Might as well add a test for 48000, which is anoth Might as well add a test for 48000, which is another very common sample rate. KhNo 2014/07/31 16:45:53 I agree with you, if there are famous values shoul Show quoted text On 2014/07/30 16:49:38, Raymond Toy wrote: > Might as well add a test for 48000, which is another very common sample rate. I agree with you, if there are famous values should be added. Raymond Toy 2014/07/31 17:25:13 Just 48000 is enough for me. Show quoted text On 2014/07/31 16:45:53, KhNo wrote: > On 2014/07/30 16:49:38, Raymond Toy wrote: > > Might as well add a test for 48000, which is another very common sample rate. > > I agree with you, if there are famous values should be added. Just 48000 is enough for me.
	23

13 </script>	24 </script>

14 </body>	25 </body>

15 </html>	26 </html>

OLD	NEW