Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: Source/modules/webaudio/AudioBuffer.cpp

Issue 375383002: Extending supported sample rate from 3.0KHz to 192.0KHz for OfflineAudioContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix as review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 26 matching lines...) Expand all
37 #include "core/dom/ExceptionCode.h" 37 #include "core/dom/ExceptionCode.h"
38 #include "platform/audio/AudioBus.h" 38 #include "platform/audio/AudioBus.h"
39 #include "platform/audio/AudioFileReader.h" 39 #include "platform/audio/AudioFileReader.h"
40 #include "modules/webaudio/AudioContext.h" 40 #include "modules/webaudio/AudioContext.h"
41 41
42 namespace blink { 42 namespace blink {
43 43
44 float AudioBuffer::minAllowedSampleRate() 44 float AudioBuffer::minAllowedSampleRate()
45 { 45 {
46 // crbug.com/344375 46 // crbug.com/344375
47 return 3000; 47 return 3000.f;
Raymond Toy 2014/09/04 17:27:20 No .f required: http://www.chromium.org/blink/cod
KhNo 2014/09/05 05:03:25 Done.
48 } 48 }
49 49
50 float AudioBuffer::maxAllowedSampleRate() 50 float AudioBuffer::maxAllowedSampleRate()
51 { 51 {
52 // Windows can support up to this rate. 52 // Windows can support up to this rate.
53 return 192000; 53 return 192000.f;
Raymond Toy 2014/09/04 17:27:20 Same as line 47.
KhNo 2014/09/05 05:03:25 Done.
54 } 54 }
55 55
56 AudioBuffer* AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrame s, float sampleRate) 56 AudioBuffer* AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrame s, float sampleRate)
57 { 57 {
58 if (sampleRate < minAllowedSampleRate() || sampleRate > maxAllowedSampleRate () || numberOfChannels > AudioContext::maxNumberOfChannels() || !numberOfChannel s || !numberOfFrames) 58 if (sampleRate < minAllowedSampleRate() || sampleRate > maxAllowedSampleRate () || numberOfChannels > AudioContext::maxNumberOfChannels() || !numberOfChannel s || !numberOfFrames)
59 return 0; 59 return 0;
60 60
61 AudioBuffer* buffer = new AudioBuffer(numberOfChannels, numberOfFrames, samp leRate); 61 AudioBuffer* buffer = new AudioBuffer(numberOfChannels, numberOfFrames, samp leRate);
62 62
63 if (!buffer->createdSuccessfully(numberOfChannels)) 63 if (!buffer->createdSuccessfully(numberOfChannels))
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 { 209 {
210 for (unsigned i = 0; i < m_channels.size(); ++i) { 210 for (unsigned i = 0; i < m_channels.size(); ++i) {
211 if (getChannelData(i)) 211 if (getChannelData(i))
212 getChannelData(i)->zeroRange(0, length()); 212 getChannelData(i)->zeroRange(0, length());
213 } 213 }
214 } 214 }
215 215
216 } // namespace blink 216 } // namespace blink
217 217
218 #endif // ENABLE(WEB_AUDIO) 218 #endif // ENABLE(WEB_AUDIO)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698