Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375363002: Makes sure InputMethodEngine::Enable() can be called after chrome starts. (Closed)

Created:
6 years, 5 months ago by Shu Chen
Modified:
6 years, 5 months ago
Reviewers:
Seigo Nonaka, Yuki
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Makes sure InputMethodEngine::Enable() can be called after chrome starts. BUG=391674 TEST=Verified on pixel device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282543

Patch Set 1 #

Patch Set 2 : fixed unit_tests #

Patch Set 3 : changed solution to mitigate risk of breaking other stuff. #

Patch Set 4 : fixed browser_tests #

Patch Set 5 : #

Patch Set 6 : change solution, mitigate risk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Shu Chen
Nona, can you please help review this cl? Thanks
6 years, 5 months ago (2014-07-09 13:21:30 UTC) #1
Yuki
lgtm
6 years, 5 months ago (2014-07-10 03:18:14 UTC) #2
Yuki
lgtm lgtm
6 years, 5 months ago (2014-07-10 03:18:15 UTC) #3
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 5 months ago (2014-07-10 03:44:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/375363002/40001
6 years, 5 months ago (2014-07-10 03:48:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 05:45:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 07:06:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/46224)
6 years, 5 months ago (2014-07-10 07:06:37 UTC) #8
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 5 months ago (2014-07-11 01:31:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/375363002/100001
6 years, 5 months ago (2014-07-11 01:32:28 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 04:46:43 UTC) #11
Message was sent while issue was closed. 
Change committed as 282543

Powered by Google App Engine
This is Rietveld 408576698