Source/modules/geolocation/GeofencingRegion.idl - Issue 375353002: Add the first very basic bits of a geofencing API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/geolocation/GeofencingRegion.idl

Issue 375353002: Add the first very basic bits of a geofencing API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/geolocation/CircularRegion.idl ('K') | « Source/modules/geolocation/GeofencingRegion.h ('k') | Source/modules/geolocation/Geolocation.h » ('j') | Source/modules/geolocation/Geolocation.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 NoInterfaceObject,	6 RuntimeEnabled=Geofencing,
Peter Beverloo 2014/07/10 16:31:36 Why did you decide to remove \|NoInterfaceObject\| h Why did you decide to remove \|NoInterfaceObject\| here? Is the GeofencingRegion constructable, or could developers do something useful with it when it's exposed (e.g. extend its prototype)? Marijn Kruisselbrink 2014/07/11 10:06:39 I removed it because you told me to add Exposed=Wi Show quoted text On 2014/07/10 16:31:36, Peter Beverloo wrote: > Why did you decide to remove \|NoInterfaceObject\| here? Is the GeofencingRegion > constructable, or could developers do something useful with it when it's exposed > (e.g. extend its prototype)? I removed it because you told me to add Exposed=Window&Worker to this interface as well (and the two attributes are mutually exclusive). But yes, I think NoInterfaceObject would be the correct attribute, so I've changed it back.
	7 Exposed=Window&Worker,

7 GarbageCollected,	8 GarbageCollected,

8 ] interface GamepadButton {	9 ] interface GeofencingRegion {

9 readonly attribute boolean pressed;	10 readonly attribute DOMString id;

10 readonly attribute double value;

11 };	11 };

OLD	NEW