Add the first very basic bits of a geofencing API.

Source/modules/geolocation/GeofencingRegion.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GeofencingRegion_h
+#define GeofencingRegion_h
+
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "platform/heap/Handle.h"
+#include "wtf/text/WTFString.h"
+
+namespace WebCore {
+
+class GeofencingRegion : public GarbageCollectedFinalized<GeofencingRegion>, public ScriptWrappable {

[Peter Beverloo, 2014/07/10 13:17:28]

Use GarbageCollected, since you don't have a destructor.

[Marijn Kruisselbrink, 2014/07/10 15:11:01]

That's what I had in PS1, it didn't compile with:
../../third_party/WebKit/Source/modules/geolocation/GeofencingRegion.h:14:1:error:
[blink-gc] Class 'GeofencingRegion' requires finalization.
class GeofencingRegion : public GarbageCollected<GeofencingRegion>, public
ScriptWrappable {
^
../../third_party/WebKit/Source/modules/geolocation/GeofencingRegion.h:14:69:
note: [blink-gc] Base class 'ScriptWrappable' requiring finalization declared
here:
class GeofencingRegion : public GarbageCollected<GeofencingRegion>, public
ScriptWrappable {
                                                                    ^
../../third_party/WebKit/Source/modules/geolocation/GeofencingRegion.h:27:5:
note: [blink-gc] Field 'm_id' requiring finalization declared here:
    String m_id;

[Peter Beverloo, 2014/07/10 16:31:36]

Aah, the String destructor. Indeed, but please just define an empty virtual
destructor (in child classes as well) to ensure that we destroy the right class
and its members.

[Marijn Kruisselbrink, 2014/07/11 10:06:39]

Done.

+    WTF_MAKE_NONCOPYABLE(GeofencingRegion);
+public:
+    void trace(Visitor*) { }

[Peter Beverloo, 2014/07/10 13:17:28]

virtual void trace(Visitor*) { }

I personally prefer the trace() method to come last in the public section,
because it's not part of this class' purpose, annotated by a comment stating
that it's implementing GarbageCollected.

[Marijn Kruisselbrink, 2014/07/10 15:11:01]

It seems the vast majority of code doesn't have any kind of comment annotating
their trace methods, but if it's preferred I can of course add one (or I can
probably just remove the entire method since it is empty anyway?)

[Peter Beverloo, 2014/07/10 16:31:36]

It's my preference as a reviewer, you're welcome to have another opinion.

I would still define an empty virtual trace method, as there are 62 of those.
Please be sure to mark it as virtual.

[Marijn Kruisselbrink, 2014/07/11 10:06:39]

Done.

+
+    String id() const { return m_id; }
+
+protected:
+    GeofencingRegion()

[Peter Beverloo, 2014/07/10 13:17:28]

This constructor isn't being used.

[Marijn Kruisselbrink, 2014/07/10 15:11:01]

Good point, removed. If I later turn out to need it I can always re-add it.

+    {
+        ScriptWrappable::init(this);
+    }
+    GeofencingRegion(const String& id) : m_id(id)
+    {
+        ScriptWrappable::init(this);
+    }
+
+private:
+    String m_id;
+};
+
+} // namespace WebCore
+
+#endif