Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 375343003: Map all ContextDestroyed custom element exceptions to InvalidStateError. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Map all ContextDestroyed custom element exceptions to InvalidStateError. For the exceptions that document.registerElement() may throw due to the context having gone away, map them all to InvalidStateError. Specifically, map ContextDestroyedRegisteringDefinition to InvalidStateError rather than NotSupportedError. R=haraken@chromium.org,ager@chromium.org,dominicc@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M LayoutTests/OilpanExpectations View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-attribute-changed-retrieval-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-register-created-retrieval-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementException.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
sof
Please take a look. I think it makes sense to be consistent about what DOM ...
6 years, 5 months ago (2014-07-10 08:14:32 UTC) #1
haraken
LGTM, but dominicc@ should confirm.
6 years, 5 months ago (2014-07-10 08:22:22 UTC) #2
Mads Ager (chromium)
LGTM2, thanks for taking care of these and sorry for leaving the XYZ in the ...
6 years, 5 months ago (2014-07-10 08:27:52 UTC) #3
dominicc (has gone to gerrit)
On 2014/07/10 08:27:52, Mads Ager (chromium) wrote: > LGTM2, thanks for taking care of these ...
6 years, 5 months ago (2014-07-11 06:00:23 UTC) #4
sof
On 2014/07/11 06:00:23, dominicc wrote: > On 2014/07/10 08:27:52, Mads Ager (chromium) wrote: > > ...
6 years, 5 months ago (2014-07-11 06:05:24 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-11 06:05:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/375343003/1
6 years, 5 months ago (2014-07-11 06:06:18 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 06:59:37 UTC) #8
Message was sent while issue was closed.
Change committed as 177907

Powered by Google App Engine
This is Rietveld 408576698