Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 375313002: Expose isEmailField() for input element (Closed)

Created:
6 years, 5 months ago by pals
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Expose isEmailField() for input element Motivation is to replace instances of "element.formControlType() == WebString::fromUTF8("email")" with isEmailField(). BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/web/WebInputElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebInputElement.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pals
PTAL.
6 years, 5 months ago (2014-07-09 12:00:10 UTC) #1
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-09 16:56:27 UTC) #2
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 5 months ago (2014-07-09 17:46:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/375313002/1
6 years, 5 months ago (2014-07-09 17:47:07 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 21:05:09 UTC) #5
Message was sent while issue was closed.
Change committed as 177770

Powered by Google App Engine
This is Rietveld 408576698