Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/test/pixel_test.cc

Issue 375303002: cc: Refactor ResourceProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/resources/scoped_gpu_raster.cc ('K') | « cc/resources/scoped_gpu_raster.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/pixel_test.cc
diff --git a/cc/test/pixel_test.cc b/cc/test/pixel_test.cc
index 73abc1c3828bd6cda9eab556cda460fff187ea9e..c5f02a3f2b2a82e87ea024187379fb5a289fa1d5 100644
--- a/cc/test/pixel_test.cc
+++ b/cc/test/pixel_test.cc
@@ -25,8 +25,11 @@
#include "cc/test/pixel_test_utils.h"
#include "cc/test/test_in_process_context_provider.h"
#include "cc/test/test_shared_bitmap_manager.h"
+#include "gpu/command_buffer/client/gles2_interface.h"
#include "testing/gtest/include/gtest/gtest.h"
+using gpu::gles2::GLES2Interface;
+
namespace cc {
PixelTest::PixelTest()
@@ -71,7 +74,9 @@ bool PixelTest::RunPixelTestWithReadbackTarget(
disable_picture_quad_image_filtering_);
// Wait for the readback to complete.
- resource_provider_->Finish();
+ GLES2Interface* gl = output_surface_->context_provider()->ContextGL();
danakj 2014/07/11 16:49:04 if context_provider() isn't null. it's null when s
sohanjg 2014/07/11 17:12:45 Done.
+ if (gl)
danakj 2014/07/11 16:49:04 don't need to check gl though
sohanjg 2014/07/11 17:12:45 Done.
+ gl->Finish();
run_loop.Run();
return PixelsMatchReference(ref_file, comparator);
« cc/resources/scoped_gpu_raster.cc ('K') | « cc/resources/scoped_gpu_raster.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698