Source/core/dom/Node.idl - Issue 375293002: Node.insertBefore and Node.appendChild do not use custom binding anymore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.idl

Issue 375293002: Node.insertBefore and Node.appendChild do not use custom binding anymore (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Node.idl

diff --git a/Source/core/dom/Node.idl b/Source/core/dom/Node.idl

index 3a78085279b65c0b373651501489a0ac9de84b68..dbd8fa9dec221ed0b0d1e800a5e8c40992dae8f3 100644

--- a/Source/core/dom/Node.idl

+++ b/Source/core/dom/Node.idl

@@ -49,10 +49,10 @@

[PerWorldBindings] readonly attribute Node nextSibling;

[PerWorldBindings] readonly attribute Document ownerDocument;

- [Custom, CustomElementCallbacks, PerWorldBindings, RaisesException] Node insertBefore(Node newChild, Node refChild);

+ [CustomElementCallbacks, PerWorldBindings, RaisesException, TypeChecking=Interface] Node insertBefore(Node newChild, Node? refChild);

[Custom, CustomElementCallbacks, PerWorldBindings, RaisesException] Node replaceChild(Node newChild, Node oldChild);

[Custom, CustomElementCallbacks, RaisesException] Node removeChild(Node oldChild);

- [Custom, CustomElementCallbacks, PerWorldBindings, RaisesException] Node appendChild(Node newChild);

+ [CustomElementCallbacks, PerWorldBindings, RaisesException, TypeChecking=Interface] Node appendChild(Node newChild);

[ImplementedAs=hasChildren] boolean hasChildNodes();

[CustomElementCallbacks] Node cloneNode(optional boolean deep);

« Source/core/dom/ContainerNode.cpp ('K') | « Source/core/dom/Node.cpp ('k') | no next file » | no next file with comments »