Source/core/dom/ContainerNode.h - Issue 375293002: Node.insertBefore and Node.appendChild do not use custom binding anymore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.h

Issue 375293002: Node.insertBefore and Node.appendChild do not use custom binding anymore (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/custom/V8NodeCustom.cpp ('K') | « Source/bindings/core/v8/custom/V8NodeCustom.cpp ('k') | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/dom/ContainerNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ContainerNode.h

diff --git a/Source/core/dom/ContainerNode.h b/Source/core/dom/ContainerNode.h

index c43a52b6808ed8fe4553fae77cfed418b3144be5..fa19ba35481e0fb901d41f33f9b3cb9bb1f21810 100644

--- a/Source/core/dom/ContainerNode.h

+++ b/Source/core/dom/ContainerNode.h

@@ -84,10 +84,10 @@ public:

PassRefPtrWillBeRawPtr<Element> querySelector(const AtomicString& selectors, ExceptionState&);

PassRefPtrWillBeRawPtr<StaticNodeList> querySelectorAll(const AtomicString& selectors, ExceptionState&);

- void insertBefore(PassRefPtrWillBeRawPtr<Node> newChild, Node* refChild, ExceptionState& = ASSERT_NO_EXCEPTION);

+ PassRefPtrWillBeRawPtr<Node> insertBefore(PassRefPtrWillBeRawPtr<Node> newChild, Node* refChild, ExceptionState& = ASSERT_NO_EXCEPTION);

void replaceChild(PassRefPtrWillBeRawPtr<Node> newChild, Node* oldChild, ExceptionState& = ASSERT_NO_EXCEPTION);

void removeChild(Node* child, ExceptionState& = ASSERT_NO_EXCEPTION);

- void appendChild(PassRefPtrWillBeRawPtr<Node> newChild, ExceptionState& = ASSERT_NO_EXCEPTION);

+ PassRefPtrWillBeRawPtr<Node> appendChild(PassRefPtrWillBeRawPtr<Node> newChild, ExceptionState& = ASSERT_NO_EXCEPTION);

Element* getElementById(const AtomicString& id) const;

PassRefPtrWillBeRawPtr<TagCollection> getElementsByTagName(const AtomicString&);