LayoutTests/fast/dom/Node/fragment-mutation.html - Issue 375293002: Node.insertBefore and Node.appendChild do not use custom binding anymore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Node/fragment-mutation.html

Issue 375293002: Node.insertBefore and Node.appendChild do not use custom binding anymore (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace assert with condition Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css/invalidation/style-update-with-added-stylesheet.html ('k') | LayoutTests/fast/dom/move-nodes-across-documents.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Node/fragment-mutation.html

diff --git a/LayoutTests/fast/dom/Node/fragment-mutation.html b/LayoutTests/fast/dom/Node/fragment-mutation.html

index 84e67f6539d64b73e3511020c076e04c9e800cbf..9b772748f326c14fdf48a14e734ddc9418b6269f 100644

--- a/LayoutTests/fast/dom/Node/fragment-mutation.html

+++ b/LayoutTests/fast/dom/Node/fragment-mutation.html

@@ -36,13 +36,13 @@ function produceNodeNameString(nodes)

return result;

}

-function expectException(code)

+function expectException(error)

{

return function(stash, exception) {

if (!exception)

return "FAIL, expected exception with code " + code + ". The resulting fragment was: \"" + produceNodeNameString(stash) + "\".";

- if (code == exception.code)

+ if (exception instanceof error)

return "PASS";

return "FAIL, expected exception code: " + code + ", was: " + exception + ".";

}

@@ -122,7 +122,7 @@ function runTest(methodName, method)

testFragment(method, "Continually re-appending removed element to the fragment should eventually throw NOT_FOUND_ERR", function(evt, frag, stash)

{

stash.insertBefore(frag.lastChild, stash.firstChild);

- }, expectException(8), true);

+ }, expectException(TypeError), true);

printLog(methodName);

}

function runTests()