Node.insertBefore and Node.appendChild do not use custom binding anymore

Source/bindings/core/v8/custom/V8NodeCustom.cpp

 /*
  * Copyright (C) 2007-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 40 matching lines @@
 #include "core/dom/Document.h"
 #include "core/dom/custom/CustomElementCallbackDispatcher.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/events/EventListener.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 
 // These functions are custom to prevent a wrapper lookup of the return value which is always
 // part of the arguments.
-void V8Node::insertBeforeMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
-    v8::Handle<v8::Object> holder = info.Holder();
-    Node* impl = V8Node::toNative(holder);
-
-    CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
-
-    ExceptionState exceptionState(ExceptionState::ExecutionContext, "insertBefore", "Node", info.Holder(), info.GetIsolate());
-    Node* newChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[0]);
-    Node* refChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[1]);
-    impl->insertBefore(newChild, refChild, exceptionState);
-    if (exceptionState.throwIfNeeded())
-        return;
-    v8SetReturnValue(info, info[0]);
-}
-
 void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     v8::Handle<v8::Object> holder = info.Holder();
     Node* impl = V8Node::toNative(holder);
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "replaceChild", "Node", info.Holder(), info.GetIsolate());
     Node* newChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[0]);
     Node* oldChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[1]);
     impl->replaceChild(newChild, oldChild, exceptionState);
     if (exceptionState.throwIfNeeded())
         return;
     v8SetReturnValue(info, info[1]);
 }
 
 void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

[haraken, 2014/07/11 02:18:23]

You can consider removing these custom bindings for replaceChild and removeChild
in a follow-up CL.

[kangil_, 2014/07/11 02:39:42]

Sure I will.

 {
     v8::Handle<v8::Object> holder = info.Holder();
     Node* impl = V8Node::toNative(holder);
 
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
 
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "removeChild", "Node", info.Holder(), info.GetIsolate());
     Node* oldChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[0]);
     impl->removeChild(oldChild, exceptionState);
     if (exceptionState.throwIfNeeded())
         return;
     v8SetReturnValue(info, info[0]);
 }
 
-void V8Node::appendChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
-    ExceptionState exceptionState(ExceptionState::ExecutionContext, "appendChild", "Node", info.Holder(), info.GetIsolate());
-    if (UNLIKELY(info.Length() < 1)) {
-        throwMinimumArityTypeErrorForMethod("appendChild", "Node", 1, info.Length(), info.GetIsolate());
-        return;
-    }
-    Node* impl = V8Node::toNative(info.Holder());
-    CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
-    Node* newChild;
-    {
-        v8::TryCatch block;
-        V8RethrowTryCatchScope rethrow(block);
-        if (info.Length() > 0 && !V8Node::hasInstance(info[0], info.GetIsolate())) {
-            exceptionState.throwTypeError("parameter 1 is not of type 'Node'.");
-            exceptionState.throwIfNeeded();
-            return;
-        }
-        TONATIVE_VOID_INTERNAL(newChild, V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
-    }
-    impl->appendChild(newChild, exceptionState);
-    if (exceptionState.hadException()) {
-        exceptionState.throwIfNeeded();
-        return;
-    }
-    v8SetReturnValue(info, info[0]);
-}
-
 v8::Handle<v8::Object> wrap(Node* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     ASSERT(impl);
     switch (impl->nodeType()) {
     case Node::ELEMENT_NODE:
         // For performance reasons, this is inlined from V8Element::wrap and must remain in sync.
         if (impl->isHTMLElement())
             return wrap(toHTMLElement(impl), creationContext, isolate);
         if (impl->isSVGElement())
             return wrap(toSVGElement(impl), creationContext, isolate);
@@ skipping 14 matching lines @@
         return wrap(toDocumentType(impl), creationContext, isolate);
     case Node::DOCUMENT_FRAGMENT_NODE:
         if (impl->isShadowRoot())
             return wrap(toShadowRoot(impl), creationContext, isolate);
         return wrap(toDocumentFragment(impl), creationContext, isolate);
     }
     ASSERT_NOT_REACHED();
     return V8Node::createWrapper(impl, creationContext, isolate);
 }
 } // namespace WebCore