Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: chrome/renderer/printing/print_web_view_helper.cc

Issue 375253002: [Chrome] Support NumCopies print preset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback (oop proxy, out-param) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/printing/print_web_view_helper.cc
diff --git a/chrome/renderer/printing/print_web_view_helper.cc b/chrome/renderer/printing/print_web_view_helper.cc
index 53a66ee29263edee54837201297c2b99c9ba9d9c..36397ef743c7f067999f185e76f11ebdfe178152 100644
--- a/chrome/renderer/printing/print_web_view_helper.cc
+++ b/chrome/renderer/printing/print_web_view_helper.cc
@@ -39,6 +39,7 @@
#include "third_party/WebKit/public/web/WebPlugin.h"
#include "third_party/WebKit/public/web/WebPluginDocument.h"
#include "third_party/WebKit/public/web/WebPrintParams.h"
+#include "third_party/WebKit/public/web/WebPrintPresetOptions.h"
#include "third_party/WebKit/public/web/WebPrintScalingOption.h"
#include "third_party/WebKit/public/web/WebScriptSource.h"
#include "third_party/WebKit/public/web/WebSettings.h"
@@ -1451,8 +1452,14 @@ void PrintWebViewHelper::SetOptionsFromDocument(
blink::WebLocalFrame* source_frame = print_preview_context_.source_frame();
const blink::WebNode& source_node = print_preview_context_.source_node();
- params.is_scaling_disabled =
- source_frame->isPrintScalingDisabledForPlugin(source_node);
+ blink::WebPrintPresetOptions preset_options;
+ if (!source_frame->getPrintPresetOptionsForPlugin(source_node,
+ &preset_options)) {
+ return;
+ }
+
+ params.is_scaling_disabled = preset_options.isScalingDisabled;
+ params.copies = preset_options.copies;
}
bool PrintWebViewHelper::UpdatePrintSettings(
« no previous file with comments | « no previous file | content/renderer/pepper/pepper_plugin_instance_impl.h » ('j') | content/renderer/pepper/pepper_webplugin_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698