[Chrome] Support NumCopies print preset

ppapi/c/dev/pp_print_settings_dev.h

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /* From dev/pp_print_settings_dev.idl modified Wed Jun 13 09:14:31 2012. */
 
 #ifndef PPAPI_C_DEV_PP_PRINT_SETTINGS_DEV_H_
 #define PPAPI_C_DEV_PP_PRINT_SETTINGS_DEV_H_
 
@@ skipping 29 matching lines @@
   PP_PRINTOUTPUTFORMAT_EMF = 1u << 3
 } PP_PrintOutputFormat_Dev;
 PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_PrintOutputFormat_Dev, 4);
 
 typedef enum {
   PP_PRINTSCALINGOPTION_NONE = 0,
   PP_PRINTSCALINGOPTION_FIT_TO_PRINTABLE_AREA = 1,
   PP_PRINTSCALINGOPTION_SOURCE_SIZE = 2
 } PP_PrintScalingOption_Dev;
 PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_PrintScalingOption_Dev, 4);
+
+typedef enum {
+  PP_PRINTDUPLEXMODE_NONE = 0,
+  PP_PRINTDUPLEXMODE_SIMPLEX = 1,
+  PP_PRINTDUPLEXMODE_LONG_EDGE = 2,
+  PP_PRINTDUPLEXMODE_SHORT_EDGE = 3
+} PP_PrintDuplexMode_Dev;
+PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_PrintDuplexMode_Dev, 4);
 /**
  * @}
  */
 
 /**
  * @addtogroup Structs
  * @{
  */
 struct PP_PrintSettings_Dev {
   /** This is the size of the printable area in points (1/72 of an inch). */
   struct PP_Rect printable_area;
   struct PP_Rect content_area;
   struct PP_Size paper_size;
   int32_t dpi;
   PP_PrintOrientation_Dev orientation;
   PP_PrintScalingOption_Dev print_scaling_option;
   PP_Bool grayscale;
   /** Note that Chrome currently only supports PDF printing. */
   PP_PrintOutputFormat_Dev format;
 };
 PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_PrintSettings_Dev, 60);
+
+struct PP_PrintRange_Dev {
+  int32_t from;
+  int32_t to;
+};
+PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_PrintRange_Dev, 8);
+
+struct PP_PrintPresetOptions_Dev {

[raymes, 2014/09/24 04:54:39]

I'd prefer to move this struct into PPP_Pdf (and name it appropriately as
PP_PdfPrintPresetOptions or something). The reason being that it makes it clear
that we can change the struct at anytime without worrying about flash. When
people look at this file they have to worry about backward compatibility with
flash but that's not the case with PDF.

[raymes, 2014/10/01 17:26:23]

This part hasn't been addressed, it would be better to move the struct I think.

[Nikhil, 2014/10/07 09:53:37]

Done.

+  PP_Bool is_scaling_disabled;

[raymes, 2014/09/24 04:54:39]

Since we already have a PPP function to get whether scaling is disabled (in
PPP_Printing) I think it's better to leave this out too (otherwise it becomes
unclear which value is actually being used). I'm ok with keeping the struct with
just 1 member for now.

[Nikhil, 2014/09/29 11:15:30]

Pdf print preset requires four properties to be supported -
[1] Print scaling
[2] Number of copies
[3] Duplex mode
[4] Print range

I added all four in this struct to make it complete. 

[1] is already supported by PPP_Printing function. So, if we leave out scaling,
we would be using both PPP_Printing and PPP_Pdf for this.

And PrintWebViewHelper::SetOptionsFromDocument() would need to be modified to
call both interfaces. Please see :
https://codereview.chromium.org/375253002/diff/220001/chrome/renderer/printin...

Is that okay? Or maybe add a note that both values are same for scaling?

[raymes, 2014/10/01 17:26:23]

Ok I think you're right that it's clearer that everything is one interface. But
please put a comment in the API saying that it should return the same
information as the PPP function.

[Nikhil, 2014/10/07 09:53:37]

Done.

+  int32_t copies;
+  PP_PrintDuplexMode_Dev duplex;
+  struct PP_PrintRange_Dev page_range;
+  int32_t page_range_count;

[raymes, 2014/09/24 04:54:39]

Are the last 3 members of the struct used at all? Should we remove them?

[Nikhil, 2014/09/29 11:15:30]

They are not used right now. But I intend to support them in future CLs. 

I wasn't sure about backward compatibility changes so I added all required
fields in this CL. But since there are no concerns with backward compatibility,
I'll remove them for now :)

[raymes, 2014/10/01 17:26:23]

It's ok to keep them if they will be used, I didn't realize.

[Nikhil, 2014/10/07 09:53:37]

Acknowledged.

+};
+PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_PrintPresetOptions_Dev, 24);
 /**
  * @}
  */
 
 #endif  /* PPAPI_C_DEV_PP_PRINT_SETTINGS_DEV_H_ */