ppapi/api/dev/ppp_printing_dev.idl - Issue 375253002: [Chrome] Support NumCopies print preset

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/api/dev/ppp_printing_dev.idl

Issue 375253002: [Chrome] Support NumCopies print preset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file.	3 * found in the LICENSE file.

4 */	4 */

5	5

6 /**	6 /**

7 * Definition of the PPP_Printing interface.	7 * Definition of the PPP_Printing interface.

8 */	8 */

9	9

10 // Note: This version should always match the PPB_Printing_Dev interface.	10 // Note: This version should always match the PPB_Printing_Dev interface.

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 [in] uint32_t page_range_count);	50 [in] uint32_t page_range_count);

51	51

52 /** Ends the print session. Further calls to PrintPages will fail. */	52 /** Ends the print session. Further calls to PrintPages will fail. */

53 void End([in] PP_Instance instance);	53 void End([in] PP_Instance instance);

54	54

55 /**	55 /**

56 * Returns true if the current content should be printed into the full page	56 * Returns true if the current content should be printed into the full page

57 * and not scaled down to fit within the printer's printable area.	57 * and not scaled down to fit within the printer's printable area.

58 */	58 */

59 PP_Bool IsScalingDisabled([in] PP_Instance instance);	59 PP_Bool IsScalingDisabled([in] PP_Instance instance);

	60 /**

	61 * Returns the number of copies to be printed.

	62 */

	63 int32_t NumCopies([in] PP_Instance instance);
	Vitaly Buka (NO REVIEWS) 2014/07/10 01:13:05 name name yzshen1 2014/07/14 17:30:55 Style nits: Usually the name of a method should be Style nits: Usually the name of a method should be VerbNoun(), so maybe GetNumberOfCopies()? Besides, please put it in a newer version (by updating label struct above, and also adding [version=XXX] tag.) You probably also want to notify pepper-dev@chromium.org (or pepper-team@google.com if you want to have internal discussion) about your proposed interface change. Nikhil 2014/07/16 13:52:55 I'm unsure of this change. Please check and let me Show quoted text On 2014/07/14 17:30:55, yzshen1 wrote: > Style nits: Usually the name of a method should be VerbNoun(), so maybe > GetNumberOfCopies()? > > Besides, please put it in a newer version (by updating label struct above, and > also adding [version=XXX] tag.) > I'm unsure of this change. Please check and let me know if something should be changed. Show quoted text > You probably also want to notify mailto:pepper-dev@chromium.org (or > mailto:pepper-team@google.com if you want to have internal discussion) about your > proposed interface change. Nikhil 2014/07/16 13:52:55 Done. Show quoted text On 2014/07/10 01:13:05, Vitaly Buka wrote: > name Done.
60 };	64 };

OLD	NEW

« pdf/pdfium/pdfium_engine.h ('K') | « pdf/pdfium/pdfium_engine.cc ('k') | ppapi/c/dev/ppp_printing_dev.h » ('j') | ppapi/cpp/dev/printing_dev.h » ('J')