Issue 375243002: Move ModuleSystemTest and the tests that use it into extensions/.

Issue 375243002: Move ModuleSystemTest and the tests that use it into extensions/. (Closed)

Created:
6 years, 5 months ago by Sam McNally

Modified:
6 years, 5 months ago

Reviewers:
tfarina, Jay Civelli, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ModuleSystemTest and the tests that use it into extensions/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283580

Patch Set 2 : namespace extensions #

Total comments: 6

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -2368 lines)			Patch
M	chrome/chrome_tests_unit.gypi	View		4 chunks	+8 lines, -13 lines	0 comments	Download
D	chrome/renderer/extensions/event_unittest.cc	View		1 chunk	+0 lines, -294 lines	0 comments	Download
D	chrome/renderer/extensions/json_schema_unittest.cc	View		1 chunk	+0 lines, -98 lines	0 comments	Download
D	chrome/renderer/extensions/messaging_utils_unittest.cc	View		1 chunk	+0 lines, -197 lines	0 comments	Download
D	chrome/renderer/extensions/module_system_unittest.cc	View		1 chunk	+0 lines, -489 lines	0 comments	Download
D	chrome/renderer/extensions/safe_builtins_unittest.cc	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	chrome/renderer/extensions/utils_unittest.cc	View		1 chunk	+0 lines, -123 lines	0 comments	Download
D	chrome/test/base/module_system_test.h	View		1 chunk	+0 lines, -111 lines	0 comments	Download
D	chrome/test/base/module_system_test.cc	View		1 chunk	+0 lines, -239 lines	0 comments	Download
D	chrome/test/data/extensions/json_schema_test.js	View		1 chunk	+0 lines, -668 lines	0 comments	Download
M	extensions/extensions.gyp	View		3 chunks	+24 lines, -0 lines	0 comments	Download
A +	extensions/renderer/event_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
A +	extensions/renderer/json_schema_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	extensions/renderer/messaging_utils_unittest.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
A +	extensions/renderer/module_system_test.h	View	1	5 chunks	+11 lines, -11 lines	0 comments	Download
A +	extensions/renderer/module_system_test.cc	View	1	10 chunks	+37 lines, -35 lines	0 comments	Download
A +	extensions/renderer/module_system_unittest.cc	View	1	3 chunks	+11 lines, -13 lines	0 comments	Download
A +	extensions/renderer/safe_builtins_unittest.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
A +	extensions/renderer/utils_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	extensions/test/data/json_schema_test.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	extensions/test/extensions_unittests_main.cc	View	1	2 chunks	+15 lines, -2 lines	6 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm with a bit of namespacing. https://codereview.chromium.org/375243002/diff/80001/extensions/renderer/module_system_test.h File extensions/renderer/module_system_test.h (left): https://codereview.chromium.org/375243002/diff/80001/extensions/renderer/module_system_test.h#oldcode81 extensions/renderer/module_system_test.h:81: // TODO(kalman): move ...

6 years, 5 months ago (2014-07-10 15:22:57 UTC) #2

Sam McNally

+jcivelli for chrome/test https://codereview.chromium.org/375243002/diff/80001/extensions/renderer/module_system_test.h File extensions/renderer/module_system_test.h (right): https://codereview.chromium.org/375243002/diff/80001/extensions/renderer/module_system_test.h#newcode15 extensions/renderer/module_system_test.h:15: On 2014/07/10 15:22:56, kalman (OOO July ...

6 years, 5 months ago (2014-07-11 00:01:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/375243002/100001

6 years, 5 months ago (2014-07-16 21:06:35 UTC) #7

tfarina

https://codereview.chromium.org/375243002/diff/100001/extensions/test/extensions_unittests_main.cc File extensions/test/extensions_unittests_main.cc (right): https://codereview.chromium.org/375243002/diff/100001/extensions/test/extensions_unittests_main.cc#newcode38 extensions/test/extensions_unittests_main.cc:38: extensions::RegisterPathProvider(); are you sure you needed this? As far ...

6 years, 5 months ago (2014-07-23 02:29:44 UTC) #9

Sam McNally

6 years, 5 months ago (2014-07-23 08:27:36 UTC) #10

Message was sent while issue was closed.

https://codereview.chromium.org/375243002/diff/100001/extensions/test/extensi...
File extensions/test/extensions_unittests_main.cc (right):

https://codereview.chromium.org/375243002/diff/100001/extensions/test/extensi...
extensions/test/extensions_unittests_main.cc:38:
extensions::RegisterPathProvider();
On 2014/07/23 02:29:44, tfarina wrote:
> are you sure you needed this? As far as I can see, it is only to register
> extensions::DIR_TEST_DATA. Which you don't use here.

ModuleSystemTest uses extensions::DIR_TEST_DATA.

https://codereview.chromium.org/375243002/diff/100001/extensions/test/extensi...
extensions/test/extensions_unittests_main.cc:57: content::UnitTestTestSuite
test_suite(new ExtensionsTestSuite(argc, argv));
On 2014/07/23 02:29:43, tfarina wrote:
> why content::UnitTestTestSuite here?

ModuleSystemTest expects v8 to be initialized and for there to be a current
v8::Isolate. content::UnitTestTestSuite is how it's done elsewhere.

Expand Messages | Collapse Messages