LayoutTests/fast/js/script-tests/dot-node-base-exception.js - Issue 375213003: Node.appendChild should throw TypeError when newChild is omitted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/script-tests/dot-node-base-exception.js

Issue 375213003: Node.appendChild should throw TypeError when newChild is omitted (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/Node/append-child-error.html ('K') | « LayoutTests/fast/js/dot-node-base-exception-expected.txt ('k') | Source/bindings/core/v8/custom/V8NodeCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/script-tests/dot-node-base-exception.js

diff --git a/LayoutTests/fast/js/script-tests/dot-node-base-exception.js b/LayoutTests/fast/js/script-tests/dot-node-base-exception.js

index 201e0a9b04fc41acb3b315cc766799078b26485b..2035bbac88dd03cbf44da4fefb05c52b01a14711 100644

--- a/LayoutTests/fast/js/script-tests/dot-node-base-exception.js

+++ b/LayoutTests/fast/js/script-tests/dot-node-base-exception.js

@@ -2,5 +2,5 @@ description(

"This test checks that a correct exception is raised when calculating the base value of a dot expression fails."

);

-// Should be a DOM exception, not just some "TypeError: Null value".

-shouldThrow('(document.appendChild()).foobar()', '"NotFoundError: Failed to execute \'appendChild\' on \'Node\': The new child element is null."');

+// Should throw TypeError with appropriate message.

+shouldThrow('(document.appendChild()).foobar()', '"TypeError: Failed to execute \'appendChild\' on \'Node\': 1 argument required, but only 0 present."');