Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/js/script-tests/dot-node-base-exception.js

Issue 375213003: Node.appendChild should throw TypeError when newChild is omitted (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take review comment into consideration Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/js/dot-node-base-exception-expected.txt ('k') | Source/bindings/core/v8/custom/V8NodeCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 description( 1 description(
2 "This test checks that a correct exception is raised when calculating the base v alue of a dot expression fails." 2 "This test checks that a correct exception is raised when calculating the base v alue of a dot expression fails."
3 ); 3 );
4 4
5 // Should be a DOM exception, not just some "TypeError: Null value". 5 // Should throw TypeError with appropriate message.
6 shouldThrow('(document.appendChild()).foobar()', '"NotFoundError: Failed to exec ute \'appendChild\' on \'Node\': The new child element is null."'); 6 shouldThrow('(document.appendChild()).foobar()', '"TypeError: Failed to execute \'appendChild\' on \'Node\': 1 argument required, but only 0 present."');
OLDNEW
« no previous file with comments | « LayoutTests/fast/js/dot-node-base-exception-expected.txt ('k') | Source/bindings/core/v8/custom/V8NodeCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698