Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 375213002: net-internals: Fallback debug log store when non-native path is download target. (Closed)

Created:
6 years, 5 months ago by kinaba
Modified:
6 years, 5 months ago
Reviewers:
mmenke
CC:
chromium-reviews, eroman
Project:
chromium
Visibility:
Public.

Description

net-internals: Fallback debug log store when non-native path is download target. Download destination on Chrome OS may be a virtual path that needs to be acccessed via JavaScript FileSystem API. As a work around, when such a path is set, fall back to the initial default directory that is always a native local location. BUG=381575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
mmenke: PTAL.
6 years, 5 months ago (2014-07-09 07:15:51 UTC) #1
mmenke
On 2014/07/09 07:15:51, kinaba wrote: > mmenke: PTAL. LGTM
6 years, 5 months ago (2014-07-09 14:20:33 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-09 14:22:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/375213002/1
6 years, 5 months ago (2014-07-09 14:24:39 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 15:46:58 UTC) #5
Message was sent while issue was closed.
Change committed as 282045

Powered by Google App Engine
This is Rietveld 408576698