aw: Only enable webgl on hardware webview

aw: Only enable webgl on hardware webview

Also clean up 2d canvas code to respect command line switches.

BUG=392663
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282220

[no sievers, 2014-07-09 22:59:26]

lgtm with one question

https://codereview.chromium.org/375193002/diff/20001/android_webview/native/a...
File android_webview/native/aw_settings.cc (right):

https://codereview.chromium.org/375193002/diff/20001/android_webview/native/a...
android_webview/native/aw_settings.cc:417:
web_prefs->accelerated_2d_canvas_enabled;
So before we specifically looked at the cmdline for disabling accel. canvas.
After we don't anymore. Is that ok?

[boliu, 2014-07-09 23:03:06]

https://codereview.chromium.org/375193002/diff/20001/android_webview/native/a...
File android_webview/native/aw_settings.cc (right):

https://codereview.chromium.org/375193002/diff/20001/android_webview/native/a...
android_webview/native/aw_settings.cc:417:
web_prefs->accelerated_2d_canvas_enabled;
On 2014/07/09 22:59:26, sievers wrote:
> So before we specifically looked at the cmdline for disabling accel. canvas.
> After we don't anymore. Is that ok?

We do still take it into account. This is called from OverrideWebkitPrefs which
is *after* content already poplulates what it thinks should be the prefs. So if
either webgl or canvas should be disabled by content switches, it would be false
by this point. That's why we are and-ing the these with our setting.

This just looks weird for canvas because we had a hack to enable/disable it with
size preference rather than the enable/disable preference

[boliu, 2014-07-09 23:19:59]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-07-09 23:21:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boliu@chromium.org/375193002/20001

[commit-bot: I haz the power, 2014-07-10 02:46:13]

Change committed as 282220