Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2583)

Unified Diff: athena/activity/activity_view_manager_impl.cc

Issue 375143002: Use Widget frame and WidgetDelegate in ActvityWidget (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/activity/activity_frame_view.cc ('k') | athena/activity/activity_widget_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/activity/activity_view_manager_impl.cc
diff --git a/athena/activity/activity_view_manager_impl.cc b/athena/activity/activity_view_manager_impl.cc
index a67e6bbd2f5be48845ed79747149fd01464e7716..d174875968a38e1c076aea836b0501a46e19e022 100644
--- a/athena/activity/activity_view_manager_impl.cc
+++ b/athena/activity/activity_view_manager_impl.cc
@@ -7,48 +7,31 @@
#include <algorithm>
#include <map>
+#include "athena/activity/activity_widget_delegate.h"
#include "athena/activity/public/activity.h"
#include "athena/activity/public/activity_view_model.h"
#include "athena/screen/public/screen_manager.h"
#include "ui/aura/window.h"
-#include "ui/views/background.h"
-#include "ui/views/controls/label.h"
-#include "ui/views/layout/layout_manager.h"
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
namespace athena {
namespace {
-class ActivityWidget : public views::LayoutManager {
+class ActivityWidget {
public:
explicit ActivityWidget(Activity* activity)
- : activity_(activity),
- container_(NULL),
- title_(NULL),
- content_(NULL),
- widget_(NULL) {
- container_ = new views::View;
-
- title_ = new views::Label();
- title_->SetHorizontalAlignment(gfx::ALIGN_CENTER);
- const gfx::FontList& font_list = title_->font_list();
- title_->SetFontList(font_list.Derive(1, gfx::Font::BOLD));
- title_->SetEnabledColor(SK_ColorBLACK);
- container_->AddChildView(title_);
- container_->SetLayoutManager(this);
- content_ = activity->GetActivityViewModel()->GetContentsView();
- container_->AddChildView(content_);
-
+ : activity_(activity), widget_(NULL) {
+ ActivityViewModel* view_model = activity->GetActivityViewModel();
widget_ = new views::Widget;
views::Widget::InitParams params(
- views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
+ view_model->UsesFrame()
+ ? views::Widget::InitParams::TYPE_WINDOW
+ : views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
params.context = ScreenManager::Get()->GetContext();
- params.delegate = NULL;
+ params.delegate = new ActivityWidgetDelegate(view_model);
params.activatable = views::Widget::InitParams::ACTIVATABLE_YES;
widget_->Init(params);
- widget_->SetContentsView(container_);
-
activity_->GetActivityViewModel()->Init();
}
@@ -60,41 +43,12 @@ class ActivityWidget : public views::LayoutManager {
}
void Update() {
- title_->SetText(activity_->GetActivityViewModel()->GetTitle());
- SkColor bgcolor =
- activity_->GetActivityViewModel()->GetRepresentativeColor();
- title_->set_background(views::Background::CreateSolidBackground(bgcolor));
- title_->SetBackgroundColor(bgcolor);
+ widget_->UpdateWindowTitle();
}
private:
- // views::LayoutManager:
- virtual void Layout(views::View* host) OVERRIDE {
- CHECK_EQ(container_, host);
- const gfx::Rect& content_bounds = host->bounds();
- const int kTitleHeight = 25;
- title_->SetBounds(0, 0, content_bounds.width(), kTitleHeight);
- content_->SetBounds(0,
- kTitleHeight,
- content_bounds.width(),
- content_bounds.height() - kTitleHeight);
- }
-
- virtual gfx::Size GetPreferredSize(const views::View* host) const OVERRIDE {
- CHECK_EQ(container_, host);
- gfx::Size size;
- gfx::Size label_size = title_->GetPreferredSize();
- gfx::Size content_size = content_->GetPreferredSize();
-
- size.set_width(std::max(label_size.width(), content_size.width()));
- size.set_height(label_size.height() + content_size.height());
- return size;
- }
Activity* activity_;
- views::View* container_;
- views::Label* title_;
- views::View* content_;
views::Widget* widget_;
DISALLOW_COPY_AND_ASSIGN(ActivityWidget);
« no previous file with comments | « athena/activity/activity_frame_view.cc ('k') | athena/activity/activity_widget_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698