Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375143002: Use Widget frame and WidgetDelegate in ActvityWidget (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use Widget frame and WidgetDelegate in ActvityWidget BUG=389170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282595

Patch Set 1 : #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -71 lines) Patch
A athena/activity/activity_frame_view.h View 1 chunk +58 lines, -0 lines 0 comments Download
A athena/activity/activity_frame_view.cc View 1 1 chunk +101 lines, -0 lines 0 comments Download
M athena/activity/activity_view_manager_impl.cc View 1 2 chunks +9 lines, -55 lines 0 comments Download
A athena/activity/activity_widget_delegate.h View 1 chunk +39 lines, -0 lines 0 comments Download
A athena/activity/activity_widget_delegate.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M athena/activity/public/activity_view_model.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M athena/athena.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M athena/content/app_activity.h View 1 chunk +3 lines, -2 lines 0 comments Download
M athena/content/app_activity.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M athena/content/web_activity.h View 3 chunks +4 lines, -3 lines 0 comments Download
M athena/content/web_activity.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M athena/test/sample_activity.h View 1 chunk +3 lines, -2 lines 0 comments Download
M athena/test/sample_activity.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
6 years, 5 months ago (2014-07-11 01:14:17 UTC) #1
Jun Mukai
lgtm with nits https://codereview.chromium.org/375143002/diff/180001/athena/activity/activity_frame_view.cc File athena/activity/activity_frame_view.cc (right): https://codereview.chromium.org/375143002/diff/180001/athena/activity/activity_frame_view.cc#newcode60 athena/activity/activity_frame_view.cc:60: // No window masks in Aura. ...
6 years, 5 months ago (2014-07-11 01:28:14 UTC) #2
oshima
https://codereview.chromium.org/375143002/diff/180001/athena/activity/activity_frame_view.cc File athena/activity/activity_frame_view.cc (right): https://codereview.chromium.org/375143002/diff/180001/athena/activity/activity_frame_view.cc#newcode60 athena/activity/activity_frame_view.cc:60: // No window masks in Aura. On 2014/07/11 01:28:14, ...
6 years, 5 months ago (2014-07-11 06:51:35 UTC) #3
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-11 06:59:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/375143002/200001
6 years, 5 months ago (2014-07-11 07:05:13 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 09:29:14 UTC) #6
Message was sent while issue was closed. 
Change committed as 282595

Powered by Google App Engine
This is Rietveld 408576698