Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: ppapi/tests/test_file_mapping.cc

Issue 375133003: Fixes for re-enabling more MSVC level 4 warnings: ppapi/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Attempt build fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/proxy/ppb_instance_proxy.cc ('k') | ppapi/tests/test_graphics_2d.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/tests/test_file_mapping.h" 5 #include "ppapi/tests/test_file_mapping.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 8
9 #include <limits> 9 #include <limits>
10 #include <string> 10 #include <string>
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result()); 296 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
297 ASSERT_EQ(NULL, address); 297 ASSERT_EQ(NULL, address);
298 // TODO(dmichael): Check & test length that is not a multiple of page size??? 298 // TODO(dmichael): Check & test length that is not a multiple of page size???
299 299
300 // Bad protection. 300 // Bad protection.
301 callback.WaitForResult( 301 callback.WaitForResult(
302 file_mapping_if_->Map( 302 file_mapping_if_->Map(
303 instance_->pp_instance(), 303 instance_->pp_instance(),
304 file_io.pp_resource(), 304 file_io.pp_resource(),
305 page_size, 305 page_size,
306 ~PP_FILEMAPPROTECTION_READ, 306 ~static_cast<uint32_t>(PP_FILEMAPPROTECTION_READ),
307 PP_FILEMAPFLAG_PRIVATE, 307 PP_FILEMAPFLAG_PRIVATE,
308 0, 308 0,
309 &address, 309 &address,
310 callback.GetCallback().pp_completion_callback())); 310 callback.GetCallback().pp_completion_callback()));
311 CHECK_CALLBACK_BEHAVIOR(callback); 311 CHECK_CALLBACK_BEHAVIOR(callback);
312 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result()); 312 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
313 ASSERT_EQ(NULL, address); 313 ASSERT_EQ(NULL, address);
314 314
315 // No flags. 315 // No flags.
316 callback.WaitForResult( 316 callback.WaitForResult(
(...skipping 25 matching lines...) Expand all
342 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result()); 342 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
343 ASSERT_EQ(NULL, address); 343 ASSERT_EQ(NULL, address);
344 344
345 // Bad flags. 345 // Bad flags.
346 callback.WaitForResult( 346 callback.WaitForResult(
347 file_mapping_if_->Map( 347 file_mapping_if_->Map(
348 instance_->pp_instance(), 348 instance_->pp_instance(),
349 file_io.pp_resource(), 349 file_io.pp_resource(),
350 page_size, 350 page_size,
351 PP_FILEMAPPROTECTION_READ, 351 PP_FILEMAPPROTECTION_READ,
352 ~PP_FILEMAPFLAG_SHARED, 352 ~static_cast<uint32_t>(PP_FILEMAPFLAG_SHARED),
353 0, 353 0,
354 &address, 354 &address,
355 callback.GetCallback().pp_completion_callback())); 355 callback.GetCallback().pp_completion_callback()));
356 CHECK_CALLBACK_BEHAVIOR(callback); 356 CHECK_CALLBACK_BEHAVIOR(callback);
357 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result()); 357 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
358 ASSERT_EQ(NULL, address); 358 ASSERT_EQ(NULL, address);
359 359
360 // Bad offset; not a multiple of page size. 360 // Bad offset; not a multiple of page size.
361 callback.WaitForResult( 361 callback.WaitForResult(
362 file_mapping_if_->Map( 362 file_mapping_if_->Map(
363 instance_->pp_instance(), 363 instance_->pp_instance(),
364 file_io.pp_resource(), 364 file_io.pp_resource(),
365 page_size, 365 page_size,
366 PP_FILEMAPPROTECTION_READ, 366 PP_FILEMAPPROTECTION_READ,
367 ~PP_FILEMAPFLAG_SHARED, 367 ~static_cast<uint32_t>(PP_FILEMAPFLAG_SHARED),
368 1, 368 1,
369 &address, 369 &address,
370 callback.GetCallback().pp_completion_callback())); 370 callback.GetCallback().pp_completion_callback()));
371 CHECK_CALLBACK_BEHAVIOR(callback); 371 CHECK_CALLBACK_BEHAVIOR(callback);
372 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result()); 372 ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
373 ASSERT_EQ(NULL, address); 373 ASSERT_EQ(NULL, address);
374 374
375 // Unmap NULL. 375 // Unmap NULL.
376 callback.WaitForResult( 376 callback.WaitForResult(
377 file_mapping_if_->Unmap( 377 file_mapping_if_->Unmap(
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 0, 530 0,
531 &new_file_contents2, 531 &new_file_contents2,
532 callback_type())); 532 callback_type()));
533 ASSERT_EQ(expected_file_contents2, new_file_contents2); 533 ASSERT_EQ(expected_file_contents2, new_file_contents2);
534 534
535 // TODO(dmichael): Test non-zero offset 535 // TODO(dmichael): Test non-zero offset
536 536
537 PASS(); 537 PASS();
538 } 538 }
539 539
OLDNEW
« no previous file with comments | « ppapi/proxy/ppb_instance_proxy.cc ('k') | ppapi/tests/test_graphics_2d.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698