Fixes for re-enabling more MSVC level 4 warnings: ppapi/ edition

Fixes for re-enabling more MSVC level 4 warnings: ppapi/ edition

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Possibly-uninitialized local variable
* Signedness mismatch

This also contains a small number of other cleanups/simplifications to nearby
code.

BUG=81439
TEST=none
R=teravest@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282133

[Peter Kasting, 2014-07-09 02:11:26]

https://codereview.chromium.org/375133003/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/ppapi_cpp/library.dsc (right):

https://codereview.chromium.org/375133003/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/ppapi_cpp/library.dsc:66: 'buffer_dev.cc',
PRESUBMIT made me add this line.  I have no idea if this is correct, and if so,
why it wasn't here already.

https://codereview.chromium.org/375133003/diff/1/ppapi/thunk/ppb_browser_font...
File ppapi/thunk/ppb_browser_font_trusted_thunk.cc (right):

https://codereview.chromium.org/375133003/diff/1/ppapi/thunk/ppb_browser_font...
ppapi/thunk/ppb_browser_font_trusted_thunk.cc:21:
enter.functions()->GetFontFamilies(instance) : PP_MakeUndefined();
I had to touch this file anyway, and since IsBrowserFont() was already using a
structure like this and it was shorter, I figured I might as well make the rest
of the file use it consistently too.

[teravest, 2014-07-09 02:55:46]

lgtm

[Peter Kasting, 2014-07-09 07:34:09]

I'm guessing all the nacl_sdk build errors are due to the library.dsc change.

I can try reverting that and re-trying this tomorrow.  However, if that is
indeed the issue, we have the problem that a presubmit error (not just warning)
is demanding I make a change that breaks the build.  That seems like a serious
issue.

[teravest, 2014-07-09 14:17:21]

+binji, who knows more about the library.dsc file than I do.

[Peter Kasting, 2014-07-09 18:37:01]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-07-09 18:38:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/375133003/20001

[binji, 2014-07-09 20:27:44]

https://codereview.chromium.org/375133003/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/ppapi_cpp/library.dsc (right):

https://codereview.chromium.org/375133003/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/ppapi_cpp/library.dsc:66: 'buffer_dev.cc',
On 2014/07/09 02:11:26, Peter Kasting wrote:
> PRESUBMIT made me add this line.  I have no idea if this is correct, and if
so,
> why it wasn't here already.

It seems this is a bug in the presubmit. This file was removed in
http://crrev.com/252978, and should not be reincluded.

The presubmit script only looks at changed files, and there's currently no way
to specify that a file should not be included. Perhaps it should be a presubmit
warning instead.

[Peter Kasting, 2014-07-09 20:33:34]

On 2014/07/09 20:27:44, binji wrote:
> The presubmit script only looks at changed files, and there's currently no way
> to specify that a file should not be included. Perhaps it should be a
presubmit
> warning instead.

That seems like a better scenario than what we have today.  Are you able to fix
this?

[binji, 2014-07-09 20:54:29]

On 2014/07/09 20:33:34, Peter Kasting wrote:
> On 2014/07/09 20:27:44, binji wrote:
> > The presubmit script only looks at changed files, and there's currently no
way
> > to specify that a file should not be included. Perhaps it should be a
> presubmit
> > warning instead.
> 
> That seems like a better scenario than what we have today.  Are you able to
fix
> this?

Fix here: http://crrev.com/379923010

[commit-bot: I haz the power, 2014-07-09 21:29:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-09 21:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-09 21:35:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Peter Kasting, 2014-07-09 21:41:20]

Committed patchset #2 manually as r282133.