chrome/common/extensions/docs/templates/private/intro_tables/content_scripts.html - Issue 375133002: Docserver: Display API features that are available to content scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/intro_tables/content_scripts.html

Issue 375133002: Docserver: Display API features that are available to content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/api_models.py ('K') | « chrome/common/extensions/docs/templates/intros/extension.html ('k') | chrome/common/extensions/docs/templates/public/extensions/content_scripts.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {{^content.contentScriptSupport.restrictedTo}}
	not at google - send to devlin 2014/07/10 17:31:27 could you reverse the order of these checks? I'd p could you reverse the order of these checks? I'd prefer to see the positive-match first (?) rather than the negative. also... I think you can do: {{?restrictedTo:content.contentScriptSupport.restrictedTo}} {{#n:restrictedTo}} ... {{/n:restrictedTo}} {{:}} ... {{/contentScriptSupport.restrictedTo}} i.e. bind contentScriptSupport.restrictedTo to restrictedTo. Pretty sure I implemented that: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/handle...
	2 Fully supported.
	not at google - send to devlin 2014/07/10 17:31:28 Arbitrary place for this comment: I noticed that t Arbitrary place for this comment: I noticed that the "Content Scripts" wraps in the i18n API. Could you add: table#intro { .title { white-space: nowrap; } } inside the .api rule in _api.scss? That should fix it.
	3 {{:}}

	4 {{#n:content.contentScriptSupport.restrictedTo}}

	5 {{^n.first}}

	6 {{^n.last}},{{/n.last}}{{?n.last}} and {{/n.last}}

	7 {{/n.first}}

	8 $(ref:{{n.parent}}.{{n.node}} {{n.node}})

	9 {{/content.contentScriptSupport.restrictedTo}} are supported.

	10 {{/content.contentScriptSupport.restrictedTo}}
	not at google - send to devlin 2014/07/10 17:31:28 could you add at the bottom here "<a href="content could you add at the bottom here "<a href="content_scripts">Learn more</a>."
OLD	NEW