Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 375073002: Navigation transitions: Exposed "insertCSS" to WebContents (Closed)

Created:
6 years, 5 months ago by shatch
Modified:
6 years, 5 months ago
Reviewers:
Yaron, no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Navigation transitions: Exposed "insertCSS" to WebContents The navigation transition needs to apply some styles during the transition, so we need to expose this call to java. Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282504

Patch Set 1 #

Patch Set 2 : Changes from review. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_android.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
shatch
6 years, 5 months ago (2014-07-08 22:12:34 UTC) #1
Yaron
Could you move this to WebContents.java and web_contents_android.{h,cc}? I know that CVC is historically where ...
6 years, 5 months ago (2014-07-08 23:49:37 UTC) #2
shatch
On 2014/07/08 23:49:37, Yaron wrote: > Could you move this to WebContents.java and web_contents_android.{h,cc}? > ...
6 years, 5 months ago (2014-07-09 18:58:34 UTC) #3
Yaron
lgtm
6 years, 5 months ago (2014-07-09 20:30:25 UTC) #4
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 5 months ago (2014-07-09 20:57:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/375073002/20001
6 years, 5 months ago (2014-07-09 20:59:20 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 00:47:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 00:50:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79001)
6 years, 5 months ago (2014-07-10 00:50:17 UTC) #9
shatch
Hi Daniel, ptal, looking for an owner for content/browser/web_contents/web_contents_android.*
6 years, 5 months ago (2014-07-10 16:32:40 UTC) #10
no sievers
On 2014/07/10 16:32:40, shatch wrote: > Hi Daniel, ptal, looking for an owner for > ...
6 years, 5 months ago (2014-07-10 19:15:09 UTC) #11
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 5 months ago (2014-07-10 19:30:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/375073002/20001
6 years, 5 months ago (2014-07-10 19:32:44 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 19:36:14 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 19:38:45 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79207) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/47802)
6 years, 5 months ago (2014-07-10 19:38:46 UTC) #16
shatch
The CQ bit was checked by simonhatch@chromium.org
6 years, 5 months ago (2014-07-10 20:58:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/375073002/40001
6 years, 5 months ago (2014-07-10 20:59:34 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 02:35:39 UTC) #19
Message was sent while issue was closed.
Change committed as 282504

Powered by Google App Engine
This is Rietveld 408576698