Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 375063002: Polishing binary_size tool output. (Closed)

Created:
6 years, 5 months ago by Daniel Bratell
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@inline_measure_point_20140708
Project:
chromium
Visibility:
Public.

Description

Polishing binary_size tool output. Doing some sorting and splitting of data to make large amounts of changes easier to study. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -148 lines) Patch
M tools/binary_size/explain_binary_size_delta.py View 4 chunks +141 lines, -100 lines 0 comments Download
M tools/binary_size/explain_binary_size_delta_unittest.py View 2 chunks +69 lines, -48 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Bratell
I was experimenting with changes that resulted in thousands of size changes. Then the old ...
6 years, 5 months ago (2014-07-08 21:58:20 UTC) #1
andrewhayden
On 2014/07/08 21:58:20, Daniel Bratell wrote: > I was experimenting with changes that resulted in ...
6 years, 5 months ago (2014-07-09 08:26:36 UTC) #2
Daniel Bratell
On 2014/07/09 08:26:36, andrewhayden wrote: > On 2014/07/08 21:58:20, Daniel Bratell wrote: > > I ...
6 years, 5 months ago (2014-07-09 09:09:51 UTC) #3
Daniel Bratell
Could you take another look? I've been using this output for a week now and ...
6 years, 5 months ago (2014-07-16 07:49:03 UTC) #4
andrewhayden
LGTM! Sorry, I looked at this last week and forgot to hit the button. This ...
6 years, 5 months ago (2014-07-16 09:32:35 UTC) #5
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 5 months ago (2014-07-16 09:51:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/375063002/1
6 years, 5 months ago (2014-07-16 09:53:28 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 22:13:10 UTC) #8
Message was sent while issue was closed.
Change committed as 283540

Powered by Google App Engine
This is Rietveld 408576698