Issue 375033002: Flush gcda (code coverage) files manually in iOS Platform Test.

Issue 375033002: Flush gcda (code coverage) files manually in iOS Platform Test. (Closed)

Created:
6 years, 5 months ago by Eugene But (OOO till 7-30)

Modified:
6 years, 5 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Flush gcda (code coverage) files manually in iOS Platform Test. iOS 7 does not call any code at the "end" of an app so flushing should be performed manually. BUG=392265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282195

Patch Set 1 #

Patch Set 2 : Corrected ifdef guards #

Total comments: 2

Patch Set 3 : Resolved review comment #

Patch Set 4 : Corrected include #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -3 lines)			Patch
A	testing/coverage_util_ios.h	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
A +	testing/coverage_util_ios.cc	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
M	testing/gtest.gyp	View		3 chunks	+10 lines, -1 line	0 comments	Download
A +	testing/platform_test_ios.mm	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

lgtm https://codereview.chromium.org/375033002/diff/20001/testing/coverage_util_ios.cc File testing/coverage_util_ios.cc (right): https://codereview.chromium.org/375033002/diff/20001/testing/coverage_util_ios.cc#newcode10 testing/coverage_util_ios.cc:10: #if defined(ENABLE_TEST_CODE_COVERAGE) && defined(OS_IOS) No need for defined(OS_IOS) ...

6 years, 5 months ago (2014-07-09 18:24:11 UTC) #2

Eugene But (OOO till 7-30)

Thanks! https://codereview.chromium.org/375033002/diff/20001/testing/coverage_util_ios.cc File testing/coverage_util_ios.cc (right): https://codereview.chromium.org/375033002/diff/20001/testing/coverage_util_ios.cc#newcode10 testing/coverage_util_ios.cc:10: #if defined(ENABLE_TEST_CODE_COVERAGE) && defined(OS_IOS) On 2014/07/09 18:24:11, stuartmorgan ...

6 years, 5 months ago (2014-07-09 18:29:48 UTC) #3

Eugene But (OOO till 7-30)

The CQ bit was checked by eugenebut@chromium.org

6 years, 5 months ago (2014-07-09 18:29:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenebut@chromium.org/375033002/40001

6 years, 5 months ago (2014-07-09 18:31:30 UTC) #5

Eugene But (OOO till 7-30)

The CQ bit was checked by eugenebut@chromium.org

6 years, 5 months ago (2014-07-09 20:25:00 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenebut@chromium.org/375033002/60001

6 years, 5 months ago (2014-07-09 20:27:08 UTC) #7

Message was sent while issue was closed.

Change committed as 282195

Expand Messages | Collapse Messages