Issue 37503004: Remove MemoryUsageSupport

Issue 37503004: Remove MemoryUsageSupport (Closed)

Created:
7 years, 2 months ago by pilgrim_google

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), vsevik+blink_chromium.org, caseq+blink_chromium.org, kojih, loislo+blink_chromium.org, jsbell+bindings_chromium.org, pfeldman+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, aandrey+blink_chromium.org, marja+watch_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, haraken, Nate Chapin, Inactive, darin (slow to review)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove MemoryUsageSupport Abstraction layer no longer needed in Blink. Call Platform.h methods directly. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160605

Patch Set 1 #

Patch Set 2 : re-up #

Total comments: 2

Patch Set 3 : remove layer instead #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -145 lines)			Patch
M	Source/bindings/v8/V8Initializer.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/core.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.cpp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/core/platform/MemoryUsageSupport.h	View		1 chunk	+0 lines, -69 lines	0 comments	Download
D	Source/core/platform/chromium/MemoryUsageSupportChromium.cpp	View		1 chunk	+0 lines, -72 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM, but I think there's more cleanup we could do here. https://codereview.chromium.org/37503004/diff/30001/Source/platform/MemoryUsageSupport.cpp File Source/platform/MemoryUsageSupport.cpp (right): ...

7 years, 2 months ago (2013-10-23 19:31:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/37503004/80001

7 years, 1 month ago (2013-10-25 16:07:57 UTC) #6

Message was sent while issue was closed.

Change committed as 160605

Expand Messages | Collapse Messages