sync: Support nudges from non-blocking sync types

sync/internal_api/sync_context_proxy_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/run_loop.h"
 #include "base/sequenced_task_runner.h"
 #include "sync/engine/model_type_sync_proxy_impl.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/sync_context.h"
 #include "sync/internal_api/sync_context_proxy_impl.h"
 #include "sync/sessions/model_type_registry.h"
+#include "sync/test/engine/mock_nudge_handler.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace syncer {
 
 class SyncContextProxyImplTest : public ::testing::Test {
  public:
   SyncContextProxyImplTest()
       : sync_task_runner_(base::MessageLoopProxy::current()),
         type_task_runner_(base::MessageLoopProxy::current()),
-        registry_(new ModelTypeRegistry()),
+        registry_(new ModelTypeRegistry(workers_, NULL, &nudge_handler_)),

[stanisc, 2014/07/09 22:35:25]

Consider adding a comment explaining what this NULL is and why it is OK to pass
it.

[rlarocque, 2014/07/10 00:12:29]

It's probably better to just use a real directory.  Did that instead.

         context_proxy_(sync_task_runner_, registry_->AsWeakPtr()) {}
 
   // The sync thread could be shut down at any time without warning.  This
   // function simulates such an event.
   void DisableSync() { registry_.reset(); }
 
   scoped_ptr<SyncContextProxy> GetProxy() { return context_proxy_.Clone(); }
 
  private:
   base::MessageLoop loop_;
   scoped_refptr<base::SequencedTaskRunner> sync_task_runner_;
   scoped_refptr<base::SequencedTaskRunner> type_task_runner_;
+
+  std::vector<scoped_refptr<ModelSafeWorker> > workers_;
+  MockNudgeHandler nudge_handler_;
   scoped_ptr<ModelTypeRegistry> registry_;
+
   SyncContextProxyImpl context_proxy_;
 };
 
 // Try to connect a type to a SyncContext that has already shut down.
 TEST_F(SyncContextProxyImplTest, FailToConnect1) {
   ModelTypeSyncProxyImpl themes_sync_proxy(syncer::THEMES);
   DisableSync();
   themes_sync_proxy.Enable(GetProxy());
 
   base::RunLoop run_loop_;
@@ skipping 32 matching lines @@
   themes_sync_proxy->Enable(GetProxy());
 
   base::RunLoop run_loop_;
   run_loop_.RunUntilIdle();
 
   EXPECT_TRUE(themes_sync_proxy->IsConnected());
   DisableSync();
 }
 
 }  // namespace syncer