sync/engine/nudge_handler.cc - Issue 375023002: sync: Support nudges from non-blocking sync types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/engine/nudge_handler.cc

Issue 375023002: sync: Support nudges from non-blocking sync types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: SYNC_EXPORT Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "sync/engine/update_handler.h"	5 #include "sync/engine/nudge_handler.h"

6	6

7 namespace syncer {	7 namespace syncer {

8	8

9 UpdateHandler::UpdateHandler() {}	9 NudgeHandler::NudgeHandler() {
	stanisc 2014/07/09 22:35:24 Since NudgeHandler is effectively an interface, wh Since NudgeHandler is effectively an interface, why aren't these trivial constructor and destructor inlined in the header file? rlarocque 2014/07/10 00:12:29 I've seen the windows trybots sometimes fail to li Show quoted text On 2014/07/09 22:35:24, stanisc wrote: > Since NudgeHandler is effectively an interface, why aren't these trivial > constructor and destructor inlined in the header file? I've seen the windows trybots sometimes fail to link when SYNC_EXPORT'ed functions are declared in the header file. Moving them to the .cc file fixes it, so I've started declaring even trivial functions int he .cc file as a precaution. Besides, I see no harm in moving these functions to the .cc file.
	10 }

10	11

11 UpdateHandler::~UpdateHandler() {}	12 NudgeHandler::~NudgeHandler() {

12	13 }

13	14

14 } // namespace syncer	15 } // namespace syncer

OLD	NEW