Issue 375016: Use GetSwitchValuePath.

Issue 375016: Use GetSwitchValuePath. (Closed)

Created:
11 years, 1 month ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Use GetSwitchValuePath. BUG=24672 TEST=unit_tests Patch by Thiago Farina <thiago.farina@gmail.com>;. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32093

Patch Set 3 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -32 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/plugin/plugin_thread.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/test/memory_test/memory_test.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/reliability/page_load_test.cc	View	1	3 chunks	+6 lines, -13 lines	0 comments	Download
M	webkit/tools/test_shell/node_leak_test.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/375016/diff/8001/9006 File chrome/plugin/plugin_thread.cc (right): http://codereview.chromium.org/375016/diff/8001/9006#newcode32 Line 32: switches::kPluginPath); 4 more spaces of tabbing here, ...

11 years, 1 month ago (2009-11-13 01:51:45 UTC) #2

tfarina (gmail-do not use)

http://codereview.chromium.org/375016/diff/8001/9006 File chrome/plugin/plugin_thread.cc (right): http://codereview.chromium.org/375016/diff/8001/9006#newcode32 Line 32: switches::kPluginPath); On 2009/11/13 01:51:45, Evan Martin wrote: > ...

11 years, 1 month ago (2009-11-13 01:59:06 UTC) #3

tfarina (gmail-do not use)

11 years, 1 month ago (2009-11-17 18:07:59 UTC) #6

On 2009/11/16 20:05:00, Evan Martin wrote:
> running in try server

Thanks Evan.

Expand Messages | Collapse Messages