Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375003002: Remove duration from media::Clock. (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove duration from media::Clock. It has no business being in there. Instead let Pipeline track duration and cap interpolated time values as needed. BUG=370634 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281935

Patch Set 1 : #

Total comments: 4

Patch Set 2 : nits #

Patch Set 3 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -109 lines) Patch
M media/base/android/media_source_player.cc View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M media/base/clock.h View 1 2 chunks +1 line, -15 lines 0 comments Download
M media/base/clock.cc View 4 chunks +2 lines, -23 lines 0 comments Download
M media/base/clock_unittest.cc View 1 4 chunks +9 lines, -62 lines 0 comments Download
M media/base/pipeline.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/pipeline.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scherkus (not reviewing)
6 years, 5 months ago (2014-07-08 19:39:52 UTC) #1
xhwang
lgtm % nits https://codereview.chromium.org/375003002/diff/20001/media/base/clock.h File media/base/clock.h (left): https://codereview.chromium.org/375003002/diff/20001/media/base/clock.h#oldcode65 media/base/clock.h:65: // Returns the current elapsed media ...
6 years, 5 months ago (2014-07-08 19:53:11 UTC) #2
scherkus (not reviewing)
https://codereview.chromium.org/375003002/diff/20001/media/base/clock.h File media/base/clock.h (left): https://codereview.chromium.org/375003002/diff/20001/media/base/clock.h#oldcode65 media/base/clock.h:65: // Returns the current elapsed media time. Returns 0 ...
6 years, 5 months ago (2014-07-08 21:20:04 UTC) #3
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-08 21:20:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/375003002/60001
6 years, 5 months ago (2014-07-08 21:21:49 UTC) #5
xhwang
lgtm
6 years, 5 months ago (2014-07-08 21:21:51 UTC) #6
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-08 21:50:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/375003002/80001
6 years, 5 months ago (2014-07-08 21:55:09 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:45:06 UTC) #9
Message was sent while issue was closed. 
Change committed as 281935

Powered by Google App Engine
This is Rietveld 408576698