Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 374993002: Enable rect-based targeting in views on Linux (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Enable rect-based targeting in views on Linux Rect-based targeting in views has been on by default for ChromeOS and Win since M33. Enable it on Linux too but keep the flag --disable-views-rect-based-targeting for the time being so that the feature may be toggled on and off. BUG=391852 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285618

Patch Set 1 #

Patch Set 2 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tdanderson
Sadrul, please take a look.
6 years, 5 months ago (2014-07-08 18:30:51 UTC) #1
sadrul
lgtm
6 years, 5 months ago (2014-07-10 14:20:05 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-24 18:23:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/374993002/20001
6 years, 5 months ago (2014-07-24 18:24:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 21:37:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:16:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2108)
6 years, 5 months ago (2014-07-24 22:16:30 UTC) #7
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-25 16:45:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/374993002/20001
6 years, 5 months ago (2014-07-25 16:45:45 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 17:59:46 UTC) #10
Message was sent while issue was closed.
Change committed as 285618

Powered by Google App Engine
This is Rietveld 408576698