Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tools/perf/benchmarks/indexeddb_perf.py

Issue 374943003: Update indexeddb_perf to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/indexeddb_perf.py
diff --git a/tools/perf/benchmarks/indexeddb_perf.py b/tools/perf/benchmarks/indexeddb_perf.py
index ec93f9a50e5e98448dbd0f590c05777669693970..75e3632a14a4fed2ff46c9885b447de73378ff78 100644
--- a/tools/perf/benchmarks/indexeddb_perf.py
+++ b/tools/perf/benchmarks/indexeddb_perf.py
@@ -29,6 +29,7 @@ from telemetry import benchmark
from telemetry.core import util
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import scalar
_V8_COUNTER_NAMES = [
'V8.OsMemoryAllocated',
@@ -76,9 +77,13 @@ class _IndexedDbMeasurement(page_measurement.PageMeasurement):
if key == 'OverallTestDuration':
continue
msec = float(result_dict[key])
- results.Add(key, 'ms', msec, data_type='unimportant')
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, key, 'ms', msec, important=False))
+
total += msec
- results.Add('Total Perf', 'ms', total)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, 'Total Perf', 'ms', total))
+
def CustomizeBrowserOptions(self, options):
memory.MemoryMetric.CustomizeBrowserOptions(options)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698