Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 374943002: Revert of Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org, jln (very slow on Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (https://codereview.chromium.org/374933002/) Reason for revert: [Sheriff] This was fixed already in 281762. Original issue's description: > Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit kernel. (https://codereview.chromium.org/371113003/) > > Reason for revert: > Broke clang builders: > https://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20(dbg)/builds/61819/steps/compile/logs/stdio > > Original issue's description: > > Disable two yama tests on 3.2 kernels with 32bit userland and 64bit kernel. > > > > Disabling yama restrictions is broken there. > > > > BUG=391916 > > R=jorgelo@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281666 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281757 > > TBR=jorgelo@chromium.org,keescook@chromium.org,thakis@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=391916 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281763 TBR=jorgelo@chromium.org,keescook@chromium.org,thakis@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=391916 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M sandbox/linux/services/yama_unittests.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Michael Achenbach
Created Revert of Revert of Disable yama on 3.2 kernels with 32bit userland and 64bit ...
6 years, 5 months ago (2014-07-08 16:20:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/374943002/1
6 years, 5 months ago (2014-07-08 16:22:26 UTC) #2
commit-bot: I haz the power
Change committed as 281764
6 years, 5 months ago (2014-07-08 16:23:58 UTC) #3
eseidel
Strange that this would make it in at all..
6 years, 5 months ago (2014-07-08 16:29:03 UTC) #4
Michael Achenbach
On 2014/07/08 16:29:03, eseidel wrote: > Strange that this would make it in at all.. ...
6 years, 5 months ago (2014-07-08 16:30:33 UTC) #5
Nico
Oh, it's passive-aggressive tuesday! It's a 32bit change, and the CQ doesn't test that. So ...
6 years, 5 months ago (2014-07-08 16:33:18 UTC) #6
eseidel
Woh woh woh. I'm not trying to be aggressive. Passive or otherwise. I'm sorry to ...
6 years, 5 months ago (2014-07-08 16:37:39 UTC) #7
eseidel
I see now. My "strange that this would make it in at all" was about ...
6 years, 5 months ago (2014-07-08 16:38:28 UTC) #8
Nico
Oh sorry, this was missing a ":-P" or similar; it was meant in a jokular ...
6 years, 5 months ago (2014-07-08 16:59:00 UTC) #9
eseidel
6 years, 5 months ago (2014-07-08 17:01:12 UTC) #10
Message was sent while issue was closed.
Ah text based communication. :)

Thanks for fixing. :)

Powered by Google App Engine
This is Rietveld 408576698