|
Remove DispositionChangePhase.
The problem with having a single observer method with a phase param is that it's cumbersome and error prone to use for most clients that just want to know when something *has* changed. I think it's appropriate then to create separate methods for each phase and have the client override the one (or both) that is relevant to them.
TBR=sky@chromium.org
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281874
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+135 lines, -212 lines) |
Patch |
 |
M |
mojo/aura/window_tree_host_mojo.h
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
mojo/aura/window_tree_host_mojo.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
mojo/examples/embedded_app/embedded_app.cc
|
View
|
|
1 chunk |
+4 lines, -10 lines |
0 comments
|
Download
|
 |
M |
mojo/examples/nesting_app/nesting_app.cc
|
View
|
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/lib/node.cc
|
View
|
|
6 chunks |
+49 lines, -67 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/lib/node_observer.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/lib/view.cc
|
View
|
|
1 chunk |
+6 lines, -8 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/node_observer.h
|
View
|
|
1 chunk |
+33 lines, -21 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/tests/node_unittest.cc
|
View
|
|
20 chunks |
+21 lines, -52 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
|
View
|
|
7 chunks |
+11 lines, -31 lines |
0 comments
|
Download
|
 |
M |
mojo/services/public/cpp/view_manager/view_observer.h
|
View
|
|
1 chunk |
+4 lines, -6 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|