gm/yuvtorgbeffect.cpp - Issue 374923002: Goodbye GrEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/yuvtorgbeffect.cpp

Issue 374923002: Goodbye GrEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@noref3

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/yuvtorgbeffect.cpp

diff --git a/gm/yuvtorgbeffect.cpp b/gm/yuvtorgbeffect.cpp

index b1f495e8cc54824f0bf8335ec8d6eb3ee44af898..12676f262e2477f72cd3a19487ea2b7400e3a0fd 100644

--- a/gm/yuvtorgbeffect.cpp

+++ b/gm/yuvtorgbeffect.cpp

@@ -104,7 +104,7 @@ protected:

const int indices[6][3] = {{0, 1, 2}, {0, 2, 1}, {1, 0, 2}, {1, 2, 0}, {2, 0, 1}, {2, 1, 0}};

for (int i = 0; i < 6; ++i) {

- SkAutoTUnref<GrEffectRef> effect(

+ SkAutoTUnref<GrEffect> effect(

GrYUVtoRGBEffect::Create(texture[indices[i][0]],

texture[indices[i][1]],

texture[indices[i][2]]));

« no previous file with comments | « gm/texturedomaineffect.cpp ('k') | include/core/SkColorShader.h » ('j') | no next file with comments »