Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 374913002: Use MountGuestAndGetHash() instead of MountGuest() for retail mode (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use MountGuestAndGetHash() instead of MountGuest() for retail mode Addresses crash in M37 since multi-profiles are turned on by default and user_id hash should be present at all times. BUG=316985 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281834

Patch Set 1 #

Patch Set 2 : remove log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/login/auth/parallel_authenticator.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
6 years, 5 months ago (2014-07-08 14:38:38 UTC) #1
Nikita (slow)
Verified on M37 as well.
6 years, 5 months ago (2014-07-08 14:57:12 UTC) #2
Nikita (slow)
removed log.
6 years, 5 months ago (2014-07-08 15:04:07 UTC) #3
Denis Kuznetsov (DE-MUC)
lgtm
6 years, 5 months ago (2014-07-08 15:08:04 UTC) #4
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-08 15:10:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/374913002/20001
6 years, 5 months ago (2014-07-08 15:11:02 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 21:16:51 UTC) #7
Message was sent while issue was closed.
Change committed as 281834

Powered by Google App Engine
This is Rietveld 408576698