Providing more information on why certain users can't be added to multi-profile

chrome/browser/ui/ash/session_state_delegate_chromeos.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/session_state_delegate_chromeos.h"
 
 #include "ash/multi_profile_uma.h"
 #include "ash/session/session_state_observer.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/chromeos/login/lock/screen_locker.h"
 #include "chrome/browser/chromeos/login/ui/user_adding_screen.h"
+#include "chrome/browser/chromeos/login/users/multi_profile_user_controller.h"
 #include "chrome/browser/chromeos/login/users/user_manager.h"
+#include "chrome/browser/chromeos/policy/policy_cert_service.h"
+#include "chrome/browser/chromeos/policy/policy_cert_service_factory.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "chromeos/login/login_state.h"
 #include "components/user_manager/user.h"
@@ skipping 175 matching lines @@
       if (it == logged_in_users.begin())
         it = logged_in_users.end();
       user_id = (*(--it))->email();
       break;
   }
 
   // Switch using the transformed |user_id|.
   chromeos::UserManager::Get()->SwitchActiveUser(user_id);
 }
 
+ash::SessionStateDelegate::PrimaryUserPolicy
+SessionStateDelegateChromeos::GetPrimaryUserPolicy() const {

[dzhioev (left Google), 2014/08/06 12:37:39]

This method is identical to the part of
MultiProfileUserController::IsUserAllowedInSession. Please move common code to
the new method MultiProfileUserController::GetPrimaryUserPolicy, returning
ALLOWED/NOT_ALLOWED_PRIMARY_USER_POLICY_FORBIDS/NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED
and reuse it here and in IsUserAllowedInSession.

[Roman Sorokin (ftl), 2014/08/08 09:22:00]

Done.

+  chromeos::UserManager* user_manager = chromeos::UserManager::Get();
+  CHECK(user_manager);
+
+  const user_manager::User* primary_user = user_manager->GetPrimaryUser();
+  if (!primary_user)
+    return ash::SessionStateDelegate::PRIMARY_USER_POLICY_ALLOW;
+  Profile* primary_user_profile =
+      chromeos::ProfileHelper::Get()->GetProfileByUser(primary_user);
+  const std::string primary_user_behavior =
+      primary_user_profile->GetPrefs()->GetString(
+          prefs::kMultiProfileUserBehavior);
+  if (primary_user_behavior ==
+      chromeos::MultiProfileUserController::kBehaviorNotAllowed)
+    return ash::SessionStateDelegate::PRIMARY_USER_POLICY_FORBIDS;
+
+  policy::PolicyCertService* service =
+      policy::PolicyCertServiceFactory::GetForProfile(primary_user_profile);
+  if (service && service->has_policy_certificates())
+    return ash::SessionStateDelegate::PRIMARY_USER_POLICY_CERT_TAINTED;
+
+  return ash::SessionStateDelegate::PRIMARY_USER_POLICY_ALLOW;
+}
+
 void SessionStateDelegateChromeos::AddSessionStateObserver(
     ash::SessionStateObserver* observer) {
   session_state_observer_list_.AddObserver(observer);
 }
 
 void SessionStateDelegateChromeos::RemoveSessionStateObserver(
     ash::SessionStateObserver* observer) {
   session_state_observer_list_.RemoveObserver(observer);
 }
 
@@ skipping 31 matching lines @@
 
   session_state_ = new_state;
   NotifySessionStateChanged();
 }
 
 void SessionStateDelegateChromeos::NotifySessionStateChanged() {
   FOR_EACH_OBSERVER(ash::SessionStateObserver,
                     session_state_observer_list_,
                     SessionStateChanged(session_state_));
 }