Issue 374843002: [SyncFS] [Refactoring] Change RemovePrefix() to return bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 374843002: [SyncFS] [Refactoring] Change RemovePrefix() to return bool (Closed)

Created:
6 years, 5 months ago by peria

Modified:
6 years, 5 months ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[SyncFS] [Refactoring] Change RemovePrefix() to return a boolean value. This change reduces duplicates of using StartsWithASCII(). BUG=None TEST=./unit_tests --gtest_filter="Metadata*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281810

Patch Set 1 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -25 lines)			Patch
M	chrome/browser/sync_file_system/drive_backend/drive_backend_util.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc	View	1 chunk	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/374843002/40001

6 years, 5 months ago (2014-07-08 12:04:18 UTC) #5

Message was sent while issue was closed.

Change committed as 281810

Expand Messages | Collapse Messages