Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 374833007: Use reference for paintInvalidationContainer param of invalidatePaintIfNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
835 // FIXME: |paintInvalidationContainer| should never be 0. See crbug.com/3636 99. 835 // FIXME: |paintInvalidationContainer| should never be 0. See crbug.com/3636 99.
836 void invalidatePaintUsingContainer(const RenderLayerModelObject* paintInvali dationContainer, const LayoutRect&, InvalidationReason) const; 836 void invalidatePaintUsingContainer(const RenderLayerModelObject* paintInvali dationContainer, const LayoutRect&, InvalidationReason) const;
837 837
838 // Invalidate the paint of the entire object. Called when, e.g., the color o f a border changes, or when a border 838 // Invalidate the paint of the entire object. Called when, e.g., the color o f a border changes, or when a border
839 // style changes. 839 // style changes.
840 void paintInvalidationForWholeRenderer() const; 840 void paintInvalidationForWholeRenderer() const;
841 841
842 // Invalidate the paint of a specific subrectangle within a given object. Th e rect |r| is in the object's coordinate space. 842 // Invalidate the paint of a specific subrectangle within a given object. Th e rect |r| is in the object's coordinate space.
843 void invalidatePaintRectangle(const LayoutRect&) const; 843 void invalidatePaintRectangle(const LayoutRect&) const;
844 844
845 bool invalidatePaintIfNeeded(const RenderLayerModelObject* paintInvalidation Container, 845 bool invalidatePaintIfNeeded(const RenderLayerModelObject& paintInvalidation Container,
846 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer); 846 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer);
847 847
848 // Walk the tree after layout issuing paint invalidations for renderers that have changed or moved, updating bounds that have changed, and clearing paint in validation state. 848 // Walk the tree after layout issuing paint invalidations for renderers that have changed or moved, updating bounds that have changed, and clearing paint in validation state.
849 virtual void invalidateTreeAfterLayout(const PaintInvalidationState&); 849 virtual void invalidateTreeAfterLayout(const PaintInvalidationState&);
850 850
851 virtual void invalidatePaintForOverflow(); 851 virtual void invalidatePaintForOverflow();
852 void invalidatePaintForOverflowIfNeeded(); 852 void invalidatePaintForOverflowIfNeeded();
853 853
854 bool checkForPaintInvalidation() const; 854 bool checkForPaintInvalidation() const;
855 855
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1081 // container, so callers should provide only the offset of the container wit hin it's layer. 1081 // container, so callers should provide only the offset of the container wit hin it's layer.
1082 // containerRect is a rect that has already been added for the currentLayer which is likely to 1082 // containerRect is a rect that has already been added for the currentLayer which is likely to
1083 // be a container for child elements. Any rect wholly contained by container Rect can be 1083 // be a container for child elements. Any rect wholly contained by container Rect can be
1084 // skipped. 1084 // skipped.
1085 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) cons t; 1085 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) cons t;
1086 1086
1087 // Add hit-test rects for this renderer only to the provided list. layerOffs et is the offset 1087 // Add hit-test rects for this renderer only to the provided list. layerOffs et is the offset
1088 // of this renderer within the current layer that should be used for each re sult. 1088 // of this renderer within the current layer that should be used for each re sult.
1089 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const { }; 1089 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const { };
1090 1090
1091 virtual InvalidationReason getPaintInvalidationReason(const RenderLayerModel Object* paintInvalidationContainer, 1091 virtual InvalidationReason getPaintInvalidationReason(const RenderLayerModel Object& paintInvalidationContainer,
1092 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer, 1092 const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInva lidationContainer,
1093 const LayoutRect& newBounds, const LayoutPoint& newPositionFromPaintInva lidationContainer); 1093 const LayoutRect& newBounds, const LayoutPoint& newPositionFromPaintInva lidationContainer);
1094 virtual void incrementallyInvalidatePaint(const RenderLayerModelObject* pain tInvalidationContainer, const LayoutRect& oldBounds, const LayoutRect& newBounds ); 1094 virtual void incrementallyInvalidatePaint(const RenderLayerModelObject& pain tInvalidationContainer, const LayoutRect& oldBounds, const LayoutRect& newBounds );
1095 void fullyInvalidatePaint(const RenderLayerModelObject* paintInvalidationCon tainer, InvalidationReason, const LayoutRect& oldBounds, const LayoutRect& newBo unds); 1095 void fullyInvalidatePaint(const RenderLayerModelObject& paintInvalidationCon tainer, InvalidationReason, const LayoutRect& oldBounds, const LayoutRect& newBo unds);
1096 1096
1097 private: 1097 private:
1098 const RenderLayerModelObject* enclosingCompositedContainer() const; 1098 const RenderLayerModelObject* enclosingCompositedContainer() const;
1099 1099
1100 RenderBlock* containerForFixedPosition(const RenderLayerModelObject* paintIn validationContainer = 0, bool* paintInvalidationContainerSkipped = 0) const; 1100 RenderBlock* containerForFixedPosition(const RenderLayerModelObject* paintIn validationContainer = 0, bool* paintInvalidationContainerSkipped = 0) const;
1101 1101
1102 RenderFlowThread* locateFlowThreadContainingBlock() const; 1102 RenderFlowThread* locateFlowThreadContainingBlock() const;
1103 void removeFromRenderFlowThread(); 1103 void removeFromRenderFlowThread();
1104 void removeFromRenderFlowThreadRecursive(RenderFlowThread*); 1104 void removeFromRenderFlowThreadRecursive(RenderFlowThread*);
1105 1105
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
1494 void showTree(const WebCore::RenderObject*); 1494 void showTree(const WebCore::RenderObject*);
1495 void showLineTree(const WebCore::RenderObject*); 1495 void showLineTree(const WebCore::RenderObject*);
1496 void showRenderTree(const WebCore::RenderObject* object1); 1496 void showRenderTree(const WebCore::RenderObject* object1);
1497 // We don't make object2 an optional parameter so that showRenderTree 1497 // We don't make object2 an optional parameter so that showRenderTree
1498 // can be called from gdb easily. 1498 // can be called from gdb easily.
1499 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1499 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1500 1500
1501 #endif 1501 #endif
1502 1502
1503 #endif // RenderObject_h 1503 #endif // RenderObject_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698