Issue 374833005: Simplify PangoLayout configuration.

Issue 374833005: Simplify PangoLayout configuration. (Closed)

Created:
6 years, 5 months ago by Daniel Erat

Modified:
6 years, 5 months ago

Reviewers:
msw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Simplify PangoLayout configuration. Remove SetupPangoLayout() and SetupPangoLayoutWithoutFontDescription(). Rename SetupPangoLayoutWithFontDescription() to SetUpPangoLayout() and pass a FontList to it instead of a PangoFontDescription, along with removing an unused "width" parameter. BUG=125235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281925

Patch Set 1 #

Patch Set 2 : GetDefaultFontName -> GetDefaultFontDescription #

Total comments: 2

Patch Set 3 : remove unneeded PangoContext forward declaration #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -99 lines)			Patch
M	ui/gfx/pango_util.h	View	1 2	3 chunks	+4 lines, -19 lines	0 comments	Download
M	ui/gfx/pango_util.cc	View		6 chunks	+27 lines, -53 lines	0 comments	Download
M	ui/gfx/platform_font_pango.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/gfx/platform_font_pango.cc	View	1	2 chunks	+11 lines, -17 lines	0 comments	Download
M	ui/gfx/render_text_pango.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

msw

lgtm with a nit https://codereview.chromium.org/374833005/diff/20001/ui/gfx/pango_util.h File ui/gfx/pango_util.h (right): https://codereview.chromium.org/374833005/diff/20001/ui/gfx/pango_util.h#newcode17 ui/gfx/pango_util.h:17: typedef struct _PangoContext PangoContext; nit: ...

6 years, 5 months ago (2014-07-08 20:38:31 UTC) #2

Daniel Erat

https://codereview.chromium.org/374833005/diff/20001/ui/gfx/pango_util.h File ui/gfx/pango_util.h (right): https://codereview.chromium.org/374833005/diff/20001/ui/gfx/pango_util.h#newcode17 ui/gfx/pango_util.h:17: typedef struct _PangoContext PangoContext; On 2014/07/08 20:38:31, msw wrote: ...

6 years, 5 months ago (2014-07-08 20:54:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/374833005/40001

6 years, 5 months ago (2014-07-08 21:01:31 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...

6 years, 5 months ago (2014-07-08 23:46:15 UTC) #6

Message was sent while issue was closed.

Change committed as 281925

Expand Messages | Collapse Messages