Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 374773002: Remove GTalk/O1D plugins and related code (Closed)

Created:
6 years, 5 months ago by Josh Horwich
Modified:
5 years, 8 months ago
Reviewers:
jam, zel, piman
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GTalk/O1D plugins and related code This removes some special-case code used to register and load gtbp and o1d PPAPI plugins on Linux and ChromeOS. It also removes infrastructure used to launch these plugins. TEST=Run PDF (out-of-process) and NaCl (in-process) plugins BUG=392002 Committed: https://crrev.com/01d8f26f28aba73ebd4346e296b947a2b939a1fb Cr-Commit-Position: refs/heads/master@{#324131}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -122 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 5 chunks +0 lines, -53 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 2 3 2 chunks +0 lines, -22 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 3 2 chunks +3 lines, -8 lines 0 comments Download
M content/common/pepper_plugin_list.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M content/public/common/pepper_plugin_info.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/pepper_plugin_info.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/public/common/webplugininfo.h View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jam
lgtm, woohoo! (I realize you haven't published this yet, but if I don't review it ...
6 years, 5 months ago (2014-07-14 22:53:57 UTC) #1
piman
lgtm
6 years, 5 months ago (2014-07-14 23:07:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/374773002/40001
5 years, 9 months ago (2015-03-02 19:05:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/374773002/60001
5 years, 8 months ago (2015-04-07 21:01:46 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-07 22:01:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 22:02:53 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/01d8f26f28aba73ebd4346e296b947a2b939a1fb
Cr-Commit-Position: refs/heads/master@{#324131}

Powered by Google App Engine
This is Rietveld 408576698