tools/tsan.supp - Issue 374763002: Flesh out SkMatrix typemask suppressions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/tsan.supp

Issue 374763002: Flesh out SkMatrix typemask suppressions. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Suppressions for Thread Sanitizer	1 # Suppressions for Thread Sanitizer

2 #	2 #

3 # CAREFUL! Comments must go on their own line or your suppressions will silentl y fail.	3 # CAREFUL! Comments must go on their own line or your suppressions will silentl y fail.

4	4

5 # WebP races (harmlessly) choosing function pointers for SIMD versions of some o f its functions.	5 # WebP races (harmlessly) choosing function pointers for SIMD versions of some o f its functions.

6 race:third_party/externals/libwebp	6 race:third_party/externals/libwebp

7	7

8 # Poppler races on startup.	8 # Poppler races on startup.

9 race:libpoppler.so	9 race:libpoppler.so

10 # LCMS is used by poppler, and also races.	10 # LCMS is used by poppler, and also races.

(...skipping 23 matching lines...) Expand all Loading...
34 # This calls SkRefCnt::getRefCnt(), which is not thread safe. skia:2726	34 # This calls SkRefCnt::getRefCnt(), which is not thread safe. skia:2726

35 race:SkImageFilter::filterImage	35 race:SkImageFilter::filterImage

36	36

37 # SkPathRef caches its bounding box the first time it's needed.	37 # SkPathRef caches its bounding box the first time it's needed.

38 # This will be fixed naturally once we create (from a single thread) a	38 # This will be fixed naturally once we create (from a single thread) a

39 # bounding-box hierarchy for SkRecord-based SkPictures; all bounds will come pre -cached.	39 # bounding-box hierarchy for SkRecord-based SkPictures; all bounds will come pre -cached.

40 # So just shut this up for now.	40 # So just shut this up for now.

41 race:SkPathRef::computeBounds	41 race:SkPathRef::computeBounds

42	42

43 # SkMatrix caches a type mask. If we race on this, we'll just calculate the sam e thing a few times.	43 # SkMatrix caches a type mask. If we race on this, we'll just calculate the sam e thing a few times.

	44 race:SkMatrix::getType

	45 race:SkMatrix::rectStaysRect

44 race:SkMatrix::getPerspectiveTypeMaskOnly	46 race:SkMatrix::getPerspectiveTypeMaskOnly

45	47

46 # TODO: some sort of SkRacy<T> to handle cases like SkMatrix, SkPathRef, SkPixel Ref above?	48 # TODO: some sort of SkRacy<T> to handle cases like SkMatrix, SkPathRef, SkPixel Ref above?

OLD	NEW