Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: ui/gfx/android/java_bitmap.h

Issue 374633002: SkBitmap::Config is deprecated, use SkColorType instead (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/android/java_bitmap.h
diff --git a/ui/gfx/android/java_bitmap.h b/ui/gfx/android/java_bitmap.h
index 44a17cade7442f4f8dc9550717c6268a291d2611..aa8e228289c59c8aca4d1821eeef1d9d4bf6ec53 100644
--- a/ui/gfx/android/java_bitmap.h
+++ b/ui/gfx/android/java_bitmap.h
@@ -55,7 +55,7 @@ class GFX_EXPORT JavaBitmap {
GFX_EXPORT base::android::ScopedJavaLocalRef<jobject> CreateJavaBitmap(
msw 2014/07/08 01:11:29 Update the call in content/browser/android/overscr
reed1 2014/07/08 13:01:57 I don't see a reference to CreateJavaBitmap in tha
msw 2014/07/08 16:52:07 Ah, sorry, that calls CreateJavaBitmapFromAndroidR
int width,
int height,
- SkBitmap::Config bitmap_config);
+ SkColorType color_type);
// Loads a Java-backed bitmap (android.graphics.Bitmap) from the provided
// drawable resource identifier (e.g., android:drawable/overscroll_glow). If the
@@ -75,7 +75,7 @@ GFX_EXPORT base::android::ScopedJavaLocalRef<jobject> ConvertToJavaBitmap(
GFX_EXPORT SkBitmap CreateSkBitmapFromJavaBitmap(const JavaBitmap& jbitmap);
// Returns a Skia config value for the requested input java Bitmap.Config.
msw 2014/07/08 01:11:29 nit: update comment s/Skia config value/Skia color
reed1 2014/07/08 13:01:57 Done.
-GFX_EXPORT SkBitmap::Config ConvertToSkiaConfig(jobject bitmap_config);
+GFX_EXPORT SkColorType ConvertToSkiaColorType(jobject jbitmap_config);
} // namespace gfx

Powered by Google App Engine
This is Rietveld 408576698