Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.idl

Issue 374623002: [screen-orientation] Update implementation to match recent spec changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/screen_orientation/ScreenOrientation.idl
diff --git a/Source/modules/screen_orientation/ScreenOrientation.idl b/Source/modules/screen_orientation/ScreenOrientation.idl
index f869dc547f380072cd5ab3d132e823b58d0367ab..057ad37c57456f156759e2b2ef6064941351d3be 100644
--- a/Source/modules/screen_orientation/ScreenOrientation.idl
+++ b/Source/modules/screen_orientation/ScreenOrientation.idl
@@ -2,18 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-enum OrientationType {
+enum OrientationLockType {
+ "any",
+ "natural",
+ "landscape",
+ "portrait",
"portrait-primary",
"portrait-secondary",
"landscape-primary",
"landscape-secondary"
};
-enum OrientationLockType {
- "any",
- "natural",
- "landscape",
- "portrait",
+enum OrientationType {
"portrait-primary",
"portrait-secondary",
"landscape-primary",
@@ -21,11 +21,14 @@ enum OrientationLockType {
};
[
+ GarbageCollected,
RuntimeEnabled=ScreenOrientation
-] partial interface Screen {
- readonly attribute OrientationType orientation;
+] interface ScreenOrientation : EventTarget {
+ readonly attribute unsigned short angle;
+ readonly attribute DOMString type;
- [CallWith=ScriptState] Promise lockOrientation(OrientationLockType orientation);
+ [CallWith=ScriptState] Promise lock(OrientationLockType orientation);
+ void unlock();
- void unlockOrientation();
+ attribute EventHandler onchange;
};

Powered by Google App Engine
This is Rietveld 408576698